Move Access Tokens UI to an entity Local Task / Tab

+1 for this

#6 worked for us! Going to create a patch off of the MR diff to be safe. Nice work! Thank you!

#8 was a dirty patch. Sorry, fam!

I've been using patch #9 in production for around 2 months now on a very active site & had no issues.

Having a look at the code in more detail, just a couple of minor nitpicks:

+/**
+ * Implements hook_entity_type_alter().
+ */
+function access_unpublished_entity_type_alter(array &$entity_types) {
+  // Provide link templates for the access-tokens route on all applicable
+  // entity types.
+  /** @var \Drupal\Core\Entity\EntityTypeInterface[] $entity_types */
+  foreach ($entity_types as $entity_type) {
+    if (AccessUnpublished::applicableEntityType($entity_type) &&
+        $entity_type->hasLinkTemplate('canonical')) {
+      if (!$entity_type->hasLinkTemplate('access-tokens')) {
+        $entity_type->setLinkTemplate('access-tokens', $entity_type->getLinkTemplate('canonical') . '/access-tokens');
+      }
+    }
+  }
+}

AccessUnpublished::applicableEntityType already checks for the entity type having the canonical link template, so we probably don't need to check that here too?

+ * Build the access token overview form for the provied entity.
Typo in provided

* Subscriber for entity access_unpublish routes.
I think this should be access_unpublished

Apart from that, all seems ok - will try to update the merge request with the above.

While this works well, I think it might be better to rename the tab to something more meaningful than "Access tokens".

@DamienMcKenna,

You have any thoughts? I noodled on a name for a while. Access Tokens is about as concise/meaningful as we can get without making that tab take up half the page.

Thinking of moving this into the new version and opening a new ticket for "moar better name" :D

"Unpublished access"? I think the word "token" won't be clear for non-technical users and shouldn't be used.

I could get behind that. Not much longer. I was hung up on having "token" in there somewhere to describe what the list would contain.

It might be good to have a task to rename the feature in other places, such as the tab on the content overview page. Going to put this in needs work for the tab name so i can at least remember we need to do this. Got this listed out in #3458071: 2.0.x Road Map

That would definitely be an interesting feature to have.

Especially since we added the label column to the token list.

Lots of duplicated code between the two forms that should probably be optimized.

MR 46 is based on MR 9, with shared code factored out to avoid unnecessary duplication.

Still needs a few tests and we should be ready to go.

Basic javascript functional test added.