Only display unpublished access form elements on relevant forms

We recently added some similar functionality in content lock #2916747: Consider the form operation when locking. I think it would be much nicer.

Still an issue. Happens on the form for https://www.drupal.org/docs/contributed-modules/scheduled-transitions module as well. Can we limit the alter to just the edit form?

Maybe the same as in #3207607: don't generate permissions for entity types that don't have a canonical link and check if the entity has the canonical link-template?

Yeah, that would fix the problem we have on https://www.mass.gov. Any chance you can roll similar patch here?

I think my suggestion form #5 is only part of the solution here. @moshe could you review #3207607: don't generate permissions for entity types that don't have a canonical link, that should fix the problem at least for you

I had another idea. What about adding some config to entity form displays, where you can choose if the form should be displayed or not for this form?

Came across this as well, where the element is being added in all confirmation forms (delete, replicate, etc). Not sure if I'm missing some scenarios, but here's a patch that takes a more opinionated and simplified approach, only displaying it on entity edit forms.

I think that adding a pseudo field with hook_entity_extra_field_info is the best option we have so far.

I re-rolled marcoscano's patch from #10 to work with the latest version. While this solution is not perfect, it does resolve the issue I experienced with the form showing on Scheduled Transitions node forms.

I've pushed a fix up to #3164509: Authenticated user can manage unpublished access tokens on node delete page that's pretty similar to the patch in #13 but copies code from the flag module. I think we should re-purpose this issue to do something similar to flag's hook_entity_extra_field_info() so people can hide the form on specific entity type / bundles. Going to credit @ChrisSnyder, @marcoscano and @hctom on the other issue.

I think the problem is fixed in current version:

    // Determines if the given form operation is add or edit. Prevents the
    // access unpublished form from being displayed on other random entity
    // forms, for example, the delete form.
    if (!in_array($form_object->getOperation(), ['edit', 'default'], TRUE)) {
      return;
    }

    /** @var \Drupal\Core\Entity\EntityInterface $entity */
    $entity = $form_object->getEntity();

    if (AccessUnpublished::applicableEntityType($entity->getEntityType()) && !$entity->isPublished() && !$entity->isNew()) {

Closing for now. Feel free to reopen if I missed something.