Closed (fixed)
Project:
Fullcalendar View
Version:
5.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 Jan 2023 at 14:50 UTC
Updated:
14 Feb 2023 at 14:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
maithri shetty commentedComment #5
mingsongThanks @Maithri shetty.
I am aware that the patch is based on branch 6.x. As there are a lots of work still needed for branch 6.x, I am not sure when we can have a stable release for 6.x in the near future.
Currently, the default main branch is 5.x. If you have time, could you create another patch for branch 5.x as well?
Comment #6
mingsongComment #9
maithri shetty commentedComment #10
maithri shetty commentedComment #11
maithri shetty commented@Mingsong Created patch for 5.x as well.
Comment #14
mingsongThanks @Maithri.
Merged.
Comment #15
cslevy commentedThis merge breaks the functionality. If FullcalendarViewPreprocess is a service then the dependencies should be added directly into the services.yml file, not with create method.
Something like this:
# View preprocess service.
fullcalendar_view.view_preprocess:
class: Drupal\fullcalendar_view\FullcalendarViewPreprocess
arguments: ['@language_manager', '@csrf_token', '@entity_type.manager', '@fullcalendar_view.timezone_conversion_service']
and the create method is not needed.
Comment #16
mingsongThanks @cslevy.
Good point.
Comment #17
mingsongComment #20
mingsongI believe the hot fix suggested by @cslevy from #15 patch the bug.
Please feel free to reopen it if it is still an issue.
Comment #21
kevin.bruner commentedYes, the dev branch has fixed the issue! Thank you!