Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Maithri Shetty created an issue. See original summary.

maithri shetty’s picture

Assigned: maithri shetty » Unassigned
Status: Active » Needs review
StatusFileSize
new4.17 KB

Mingsong made their first commit to this issue’s fork.

mingsong’s picture

Thanks @Maithri shetty.

I am aware that the patch is based on branch 6.x. As there are a lots of work still needed for branch 6.x, I am not sure when we can have a stable release for 6.x in the near future.

Currently, the default main branch is 5.x. If you have time, could you create another patch for branch 5.x as well?

mingsong’s picture

Version: 6.x-dev » 5.x-dev
Status: Needs review » Needs work

hardikpandya made their first commit to this issue’s fork.

maithri shetty’s picture

Assigned: Unassigned » maithri shetty
maithri shetty’s picture

Assigned: maithri shetty » Unassigned
Status: Needs work » Needs review
StatusFileSize
new9.48 KB
maithri shetty’s picture

@Mingsong Created patch for 5.x as well.

  • Mingsong committed c20eb39e on 6.x
    Issue #3334902: \Drupal calls should be avoided in classes, use...
mingsong’s picture

Status: Needs review » Fixed

Thanks @Maithri.

Merged.

cslevy’s picture

Status: Fixed » Needs work

This merge breaks the functionality. If FullcalendarViewPreprocess is a service then the dependencies should be added directly into the services.yml file, not with create method.

Something like this:

# View preprocess service.
fullcalendar_view.view_preprocess:
class: Drupal\fullcalendar_view\FullcalendarViewPreprocess
arguments: ['@language_manager', '@csrf_token', '@entity_type.manager', '@fullcalendar_view.timezone_conversion_service']

and the create method is not needed.

mingsong’s picture

Thanks @cslevy.

Good point.

mingsong’s picture

  • 813d8c90 committed on 5.x
    Issue #3334902: Hot fix for fullcalendar view preprocess service
    

  • 75bea533 committed on 6.x
    Issue #3334902 by cslevy: Hot fix for Fullcalendar View preprocess...
mingsong’s picture

Status: Needs work » Fixed

I believe the hot fix suggested by @cslevy from #15 patch the bug.

Please feel free to reopen it if it is still an issue.

kevin.bruner’s picture

Yes, the dev branch has fixed the issue! Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.