Closed (fixed)
Project:
Drupal core
Version:
10.1.x-dev
Component:
Claro theme
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 Jan 2023 at 21:03 UTC
Updated:
28 Apr 2023 at 07:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
bspeare commentedComment #5
gauravvvv commentedremoved some RTL specific styling. Added marign-inline to avoid RTL. Improved some nesting. Please review
Comment #6
smustgrave commentedSince the .css file did change can we get before/after screenshots please.
Comment #7
gauravvvv commentedAdded before and after patch screenshot, please review
Before patch

After patch

Comment #8
smustgrave commentedThanks
Comment #9
lauriiiAdded comment to the MR
Comment #10
gauravvvv commentedAddressed comment in MR.
Comment #11
smustgrave commentedMore nesting was added and didn't seem to break anything.
Comment #12
nod_Need to remove @nest
Comment #14
gauravvvv commentedRestoring status.
@nest is needed here because the ampersand & comes after the rule. If it becomes before the rule, then it's not needed
Comment #15
nod_Comment #17
nod_Patch fixes some spacing in RTL, nice.
Committed 99c88f9 and pushed to 10.1.x. Thanks!