Problem/Motivation

This is a child of #3324398: [META] Update Claro CSS with new coding standards and part of #3254529: [PLAN] Drupal CSS Modernization Initiative.

Steps to reproduce

The stylesheet at https://git.drupalcode.org/project/drupal/-/blob/10.0.x/core/themes/clar... needs to be refactored to make use of modern CSS and Drupal core's PostCSS tooling.

@todo: Add clear testing instructions to test this manually on the UI.

Proposed resolution

  • Use CSS Logical Properties where appropriate.
  • Use CSS nesting where appropriate.
  • Use existing variables (variables.pcss.css) where appropriate. Follow the proposed Drupal CSS coding standards to name the variables.
    • Add a comment when there's a value where there is not a variable like font-size: 1.23rem; /* @todo One off value. */
    • When possible, set variables at the root of the component and then map them to global theme variables:
      .entity-meta {
                --entity-meta-title-font-size: var(--font-size-h5);
      
                ... more style
              }
      
              .entity-meta__title {
                font-size: var(--entity-meta-title-font-size);
              }

Out of scope

  • Changing CSS classes
  • Drupal 9 patches

User interface changes

None. There should be no visual differences.
Please post before/after screenshots and make sure they look the same.

Issue fork drupal-3332441

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Stockfoot created an issue. See original summary.

bspeare’s picture

Version: 10.0.x-dev » 10.1.x-dev

Gauravvv made their first commit to this issue’s fork.

Gauravvvv’s picture

Status: Active » Needs review

removed some RTL specific styling. Added marign-inline to avoid RTL. Improved some nesting. Please review

smustgrave’s picture

Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative, +Needs screenshots

Since the .css file did change can we get before/after screenshots please.

Gauravvvv’s picture

Status: Needs work » Needs review
FileSize
46.02 KB
36.82 KB

Added before and after patch screenshot, please review

Before patch

After patch

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs screenshots

Thanks

lauriii’s picture

Status: Reviewed & tested by the community » Needs work

Added comment to the MR

Gauravvvv’s picture

Status: Needs work » Needs review

Addressed comment in MR.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

More nesting was added and didn't seem to break anything.

nod_’s picture

Status: Reviewed & tested by the community » Needs work

Need to remove @nest

VladimirAus made their first commit to this issue’s fork.

Gauravvvv’s picture

Status: Needs work » Reviewed & tested by the community

Restoring status.
@nest is needed here because the ampersand & comes after the rule. If it becomes before the rule, then it's not needed

nod_’s picture

  • nod_ committed 99c88f91 on 10.1.x
    Issue #3332441 by Gauravvvv: Refactor Claro's shortcut stylesheet
    
nod_’s picture

Status: Reviewed & tested by the community » Fixed

Patch fixes some spacing in RTL, nice.

Committed 99c88f9 and pushed to 10.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.