This module is still using old README.md template format in README.md file.

Follow the pattern in the README.md template.

CommentFileSizeAuthor
#4 upgrade_readme.PNG29.86 KBkavitha89

Issue fork upgrade_status-3332142

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Shubham Rathore created an issue. See original summary.

Shubham Rathore opened merge request !48

shubham rathore’s picture

shubham rathore commented
Assigned: shubham rathore » Unassigned
Status: Active » Needs review

Create MR for README.md file update.
Please review.
Thanks.

kavitha89’s picture

kavitha89 commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new upgrade_readme.PNG29.86 KB

The patch works fine and moving it to RTBC

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Priority: Normal » Minor
Status: Reviewed & tested by the community » Needs review

Since the last reviewer does not pay much attention to details, it would be better somebody else reviews the MR.

nupur badola’s picture

nupur badola commented
Status: Needs review » Reviewed & tested by the community

Patch is updated as per the readme.md file template.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Needs work

thakurnishant_06 made their first commit to this issue’s fork.

thakurnishant_06’s picture

thakurnishant_06 commented
Status: Needs work » Needs review

Kindly review the changes.
Thank you.

  • ddbb5949 committed on 4.x 
    Issue #3332142 by Shubham Rathore, thakurnishant_06, apaderno, Gábor...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Version: 8.x-3.x-dev » 4.x-dev
Status: Needs review » Fixed

Fixed file wrapping and corrected comments not properly implemented from @apaderno's review. Also removed the version number from the suggested composer command as it was quite outdated. Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.