Problem/Motivation

Right now sometimes we capitalize the name of the project as "MaxLength" and other times as "Maxlength."

"MaxLength" is slightly more readable so in the spirit of accessibility it makes sense to use this capitalization when referring to the project.

Steps to reproduce

Look at the documentation and user interface.

Proposed resolution

Replace any instances of "Maxlength" with "MaxLength"

Remaining tasks

  • ✅ Get maintainer approval for the proposed resolution
  • ✅ Implement resolution
  • ✅ Write test coverage (contact a maintainer if you need help)
  • ✅ Maintainer review via the UI
  • ✅ Maintainer Code Review #1
  • ✅ Maintainer code review #2
  • ✅ Merge into dev branch, with credit to author and participants

User interface changes

Minor text changes.

API changes

None

Data model changes

None

CommentFileSizeAuthor
#11 3329867-11.patch7.11 KBrohan-sinha
#5 3329867-5.patch7.11 KBnoorulshameera
#2 3329867-2.patch4.81 KBnoorulshameera

Issue fork maxlength-3329867

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

cedewey created an issue. See original summary.

noorulshameera’s picture

noorulshameera commented
Status: Active » Needs review
StatusFileSize
new 3329867-2.patch4.81 KB

Replaced 'maxlength' with 'MaxLength' in the code, wherever it is displaying in UI.

Status: Needs review » Needs work

The last submitted patch, 2: 3329867-2.patch, failed testing. View results

cedewey’s picture

cedewey
he/him
Primary language English
Location Denver, CO
commented

Hi Noorul,

Thanks for submitting the patch. It looks like the tests need to be updated as well so that it passes. If you can do that, that'd be great. If not, we can have one of our maintainers do that.

Thanks!

noorulshameera’s picture

noorulshameera commented
StatusFileSize
new 3329867-5.patch7.11 KB

Adding patch with updating tests

noorulshameera’s picture

noorulshameera commented
Status: Needs work » Needs review
cedewey’s picture

cedewey
he/him
Primary language English
Location Denver, CO
commented
Issue summary: View changes

I've tested this out an it works great. Thank you!

Once one other maintainer reviews the code we will merge this into the 2.0.x branch.

Charchil Khandelwal made their first commit to this issue’s fork.

joevagyok’s picture

joevagyok commented
Priority: Normal » Minor
cedewey’s picture

cedewey
he/him
Primary language English
Location Denver, CO
commented
Version: 2.0.x-dev » 2.1.x-dev
rohan-sinha’s picture

rohan-sinha commented
StatusFileSize
new 3329867-11.patch7.11 KB

Re-rolled Patch #5 for 2.1.x-dev

mahima_mathur23’s picture

mahima_mathur23 commented
Status: Needs review » Needs work

Patch #11 does not apply on Drupal 9 and Drupal 10 versions.

rckstr_rohan opened merge request !29

rohan-sinha’s picture

rohan-sinha commented
Status: Needs work » Needs review

Hi @Mahima thanks for the review, have made a MR , Taking back to Needs Review, thanks.

mahima_mathur23’s picture

mahima_mathur23 commented
Status: Needs review » Reviewed & tested by the community

Reviewed the MR.
"Maxlength" has been changed to "MaxLength" in the labels/descriptions/comments.

Moving to RTBC.

joevagyok’s picture

joevagyok commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.