Problem/Motivation

Further to the issue https://www.drupal.org/project/multiselect/issues/2188473, the multi-select type "list_number" has been replaced with "list_integer" from 8.1.x but the hook multiselect_help mentions support for "list_number" and it seems to have not been replaced yet.

Proposed resolution

We should replace the instance of "list_number" with "list_integer" in the above hook so as to avoid any confusion.

Issue fork multiselect-3329646

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ameymudras created an issue. See original summary.

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented
Version: 8.x-1.x-dev » 2.x-dev
Issue summary: View changes

Yes, it seems that "list_text" has been replaced with "list_string" in D8+ versions. See: https://git.drupalcode.org/project/multiselect/-/blob/2.x/src/Plugin/Fie...

I'll provide a merge request for this shortly.

klonos opened merge request !2

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented
Category: Bug report » Task
Status: Active » Needs review

PR ready for review: https://git.drupalcode.org/project/multiselect/-/merge_requests/2

Note that I've removed instances of "CCK", since that's a remnant of the D6 era and not a thing in recent versions of Drupal, and I also changed some unnecessary capitalization mid-sentence.

mandclu made their first commit to this issue’s fork.

mandclu’s picture

mandclu commented
Status: Needs review » Fixed

Thanks for identifying this, and for providing a fix. Nice work!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Thanks for working on this.

@mandclu Should @ameymudras get credit for creating the issue?