Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 after patch .png18.95 KBaniketj
#7 before patch.png21.4 KBaniketj
#6 commerce_migrate_d10_3328972-6.patch14.29 KBabhinavk
#5 commerce_migrate-n3328972-5.patch3.48 KBdamienmckenna
#3 3328972-3.patch3.43 KBquietone
#2 3328972-2.patch4.19 KBquietone

Issue fork commerce_migrate-3328972

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
StatusFileSize
new 3328972-2.patch4.19 KB
quietone’s picture

quietone commented
StatusFileSize
new 3328972-3.patch3.43 KB

j_ten_man made their first commit to this issue’s fork.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new commerce_migrate-n3328972-5.patch3.48 KB

Does this work?

abhinavk’s picture

abhinavk commented
Issue tags: +Drupal 10 compatibility
StatusFileSize
new commerce_migrate_d10_3328972-6.patch14.29 KB

This is new Patch with fixes from Upgrade status. Please review this.

aniketj’s picture

aniketj commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before patch.png21.4 KB
new after patch .png18.95 KB

I have tested patch #6 in Drupal 10.0.8 and 9.5.7. Patch applied cleanly and makes this module D10 compatible. Functionality is working fine for me.

Moving this to RTBC.

  • quietone committed 39aeca9f on 3.2.x 
    Issue #3328972 by quietone, DamienMcKenna: D10 compatibility

  • quietone committed bcfa8721 on 3.2.x 
    Revert "Issue #3328972 by quietone, DamienMcKenna: D10 compatibility"...

  • quietone committed 56223474 on 3.2.x 
    Issue #3328972 by DamienMcKenna: D10 compatibility
quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Fixed

I don't remember why I reverted this a while back.

After this tests are failing on Drupal 10 stable and 10.1.x

  Problem 1
    - drupal/migrate_plus[dev-5.x, 5.x-dev] require drupal/core ^9.1 -> satisfiable by drupal/core[9.1.0-alpha1, ..., 9.5.x-dev] from composer repo (https://repo.packagist.org) but drupal/core[10.1.x-dev] from path repo (core) has higher repository priority. The packages from the higher priority repository do not match your constraint and are therefore not installable. That repository is canonical so the lower priority repo's packages are not installable. See https://getcomposer.org/repoprio for details and assistance.

I'll make a new issue for that

@AbhinavK and @Aniketj, I follow To all contributors, I follow How is credit granted for Drupal core issues in this project. Therefore no credit is given for unhelpful comments in this issue.

  • quietone committed 2fce809d on 3.2.x 
    Revert "Issue #3328972 by DamienMcKenna: D10 compatibility"

This...

  • quietone committed 308e8d40 on 4.0.x 
    Issue #3328972 by DamienMcKenna: D10 compatibility

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.