Problem/Motivation

In a case that you would want to use comments on nodes things would not work the best currently. We should improve this a bit, however do not do too much, things should just work and offer basic template support, child themes should style comments better.

CommentFileSizeAuthor
#5 basic-comments-3327991-5.patch12.92 KBpivica
#5 interdiff-3327991-4-5.txt951 bytespivica
#4 basic-comments-3327991-4.patch11.95 KBpivica
#4 interdiff-3327991-3-4.txt794 bytespivica
#3 basic-comments-3327991-3.patch11.95 KBpivica
#3 interdiff-3327991-2-3.txt1.36 KBpivica
#2 basic-comments-3327991-2.patch11.16 KBpivica

Comments

pivica created an issue. See original summary.

pivica’s picture

pivica commented
Status: Active » Needs review
StatusFileSize
new basic-comments-3327991-2.patch11.16 KB

Here is a patch.

pivica’s picture

pivica commented
StatusFileSize
new interdiff-3327991-2-3.txt1.36 KB
new basic-comments-3327991-3.patch11.95 KB

Added update function which is adding new components/links.css to theme global styling library.

pivica’s picture

pivica commented
StatusFileSize
new interdiff-3327991-3-4.txt794 bytes
new basic-comments-3327991-4.patch11.95 KB

And a small fix for update regexp.

pivica’s picture

pivica commented
StatusFileSize
new interdiff-3327991-4-5.txt951 bytes
new basic-comments-3327991-5.patch12.92 KB

We need to allow wrapping of inline links so they can wrap for small screens.

Also updated patch to remove part of #3084984: Support custom form-required-mark element on state required change that got creep into this patch. The #3084984 will still not be committed until related issues are fixed first so that patch will need to be updated after new release.

Finally I've recompiled bs_bootstrap CSS.

  • pivica committed f91d7d81 on 8.x-1.x 
    Issue #3327991 by pivica: Basic support for comments and user compact...
pivica’s picture

pivica commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.