Closed (fixed)
Project:
Project Browser
Version:
1.0.x-dev
Component:
Meeting
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
16 Dec 2022 at 22:04 UTC
Updated:
30 Dec 2022 at 22:09 UTC
Jump to comment: Most recent
1️⃣ GitPod is failing right now when we spin it up, even with 9.4:PHP Fatal error: Trait "Drupal\package_manager\StatusCheckTrait" not found in /var/www/html/repos/project_browser/src/Controller/InstallReadinessController.php on line 18
| chrisfromredfin | Anyone any thoughts on this? |
| rkoller | it is already fixed in #3312289: Svelte UI for install controllers and there was also another thread about it opening a dedicated issue for: https://drupal.slack.com/archives/C01UHB4QG12/p1667919124424639 |
| timplunkett (he/him) | #3319785: Error when enabling project_browser and package_manager not enabled |
| timplunkett (he/him) | If you can install Package Manager first, you can work around it |
| chrisfromredfin | @shaal would there be a way to control the order of module installations from our button? |
| shaal | We can do things 🙂 |
| shaal | What is required ? |
2️⃣ We talked previously about trying to land #3240319: Prepare to switch to using (the future) Drupal 9 JSON:API endpoint - implement tests, etc. as a test-only implementation
| timplunkett (he/him) | @fjgarlin any further thoughts on that? |
| fjgarlin | the idea was to move the logic into a test module within PB, right? I’m totally ok with that for now.all the tests were added by @bnjmnm (thanks again), so it’d be great to have his opinion on this too. |
| timplunkett (he/him) | Yes, exactly |
| chrisfromredfin | :tadaco: that would be baller. |
| bnjmnm | I'd like to see it in too, the ability to test our UI changes against what will eventually be the default source plugin will let us catch problems that might otherwise be really unpleasant surprises appearing just before the finish line |
| fjgarlin | @bnjmnm - have you got the capacity to work on this? I could, but most likely next week. |
| bnjmnm | I should be able to. My priority is the UI installer but I don't see that consuming the whole week |
| fjgarlin | great, thanks so much :high5: |
3️⃣ I know there's still much to be thought of re: theming, but was there a rationale at not giving this classes "messages warning" ?
| chrisfromredfin | . |
4️⃣ re Svelte UI installer - #3312289: Svelte UI for install controllers
| chrisfromredfin | @bnjmnm there are 7 unresolved threads here in the MR - should/can they be resolved, or does this indicate work to be done, or is this mostly commentary? that is, there's a comment about something that surfaced during manual testing - I think it's related to the change itself and that the fix is there. |
| bnjmnm | Lets see how it looks now that Gitlab is running properly... I assume most of it is comments I left so make review easier by explaining changes that are helpful to a reviewer but not suitable to be part of the source files |
| bnjmnm | Yep, it's all authors notes outside of what you recently added |
| bnjmnm | Everything in the thread has been addressed |
| chrisfromredfin | ok wonderful. I'll keep going. Admittedly this is a tick over my head but I'll do what I can. But I've manually tested a little, and will do more, and IL:heart_eyes:ve it |
| chrisfromredfin | Inline comments are awesome here, esp. in the .svelte files |
| bnjmnm | I may be biased having wrote it, but I feel like as long as we've ruled out the really ugly stuff, this should go in sooner than later since it is an optional feature that defaults to off. I think the biggest concerns would be making sure it's truly deactivated when it's not enabled in config. |
| chrisfromredfin | I tend to agree 100% - it's beta and it's a massive step forward. |
| chrisfromredfin | Even the like intentional breaks I'm trying to do I would be good as follow-ups |
Participants:
chrisfromredfin, rkoller, tim.plunkett, shaal, fjgarlin, bnjmnm
Comments
Comment #7
chrisfromredfinComment #8
chrisfromredfin