Closed (fixed)
Project:
Modal
Version:
5.0.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
13 Dec 2022 at 15:31 UTC
Updated:
12 Aug 2023 at 20:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
avpadernoI am resetting the Assigned field, since it should be used from people who are going to work on the issue in the next hours, not from people who need more than 12 hours before starting to work on the issue or more than 12 hours to complete the work on the issue.
Comment #3
renatog commentedHello @ruthcj how are you?
Thanks a lot for using and for reporting. It helps a lot!
Yeah, good catch. We need to work on this.
My agenda is full on these days but seem that isn't so complex to fix so I'm putting the tag "Novice" to see if someone in the Drupal.org have interest to try to help contributing
Comment #4
jnlarComment #5
jnlarAttached a patch that'll alternate the data attributes, noticed a typo as well:
Which was affecting some logic in
js/modal-page.jsComment #6
renatog commented@jonarcher really good catch! Thanks a lot
@ruthcj could you verify if patch #4 solves your issue, please?
If yes I'll commit the fix for us
Thank you so much, team
Comment #7
shubham rathore commentedComment #8
shubham rathore commentedHi patch#4 work properly for me & resolve the issue.
Thank You
Comment #9
sahilgidwani commentedComment #10
sahilgidwani commented@RenatoG, I applied patch and it is working fine as per the problem description.
Comment #12
sahilgidwani commented@RenatoG, I have created a issue fork and applied patch and created MR so that it can be merged easily. Please review the PR.
Comment #13
sahilgidwani commentedComment #14
kevinquillen commentedThis is pretty major and needs to be fixed. Selecting Bootstrap 5 doesn't work at all, and since that is the latest version most people are probably going to select that.
Comment #15
kevinquillen commentedSetting back because there are new commits.
Comment #16
aldibierHi,
I've tested this fix using the branch with the latest commits and everything looks good.
This test was performed using Drupal 9.5 and Drupal 10.1 in both versions the fix works perfectly!
I'm attaching a video with all steps.
Comment #17
aldibierComment #19
renatog commentedThanks everyone