Problem/Motivation

The version: VERSION line in maxlength.libraries.yml is creating a version query string using the Drupal Core version number for the asset files, making these files cached in the browser dependent on the Core version.

Steps to reproduce

This can produce various problems after an update, as the old versions of assets might be loaded for users who have those cached.

Proposed resolution

Remove the version: VERSION lines from libraries.yml. Read more about this in a similar issue created for Entity browser module.

Remaining tasks

  • ✅Get maintainer approval for the proposed resolution
  • ✅ Implement resolution
  • ❌Write test coverage (contact a maintainer if you need help)
  • ✅Maintainer review via the UI
  • ✅Maintainer Code Review #1
  • ❌Maintainer code review #2
  • ❌Merge into dev branch, with credit to author and participants

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#7 removed-version-3326716-4.patch250 byteshimanshu_jhaloya
#5 removed-version-3326716.patch0 byteshimanshu_jhaloya
#3 remove_version_from_libraries-3326716-3.patch250 byteskeszthelyi

Issue fork maxlength-3326716

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

keszthelyi created an issue. See original summary.

atul_ghate’s picture

atul_ghate commented
Assigned: keszthelyi » atul_ghate

Hello @keszthelyi,
I will work on this issue.

keszthelyi’s picture

keszthelyi commented
StatusFileSize
new remove_version_from_libraries-3326716-3.patch250 bytes

Patch from commit 8a46a88

keszthelyi’s picture

keszthelyi commented
Issue summary: View changes
Status: Active » Needs review
himanshu_jhaloya’s picture

himanshu_jhaloya commented
StatusFileSize
new removed-version-3326716.patch0 bytes

ignore the patch

himanshu_jhaloya’s picture

himanshu_jhaloya commented
himanshu_jhaloya’s picture

himanshu_jhaloya commented
StatusFileSize
new removed-version-3326716-4.patch250 bytes

created patch please review

keszthelyi’s picture

keszthelyi commented

Hi @himanshu_jhaloya

The patch in #7 is identical to the one already posted in #3. Not sure what's the point.

keszthelyi’s picture

keszthelyi commented
joevagyok’s picture

joevagyok commented

Thanks for the patch @keszthelyi looks good. Will merge it up in dev branch and to be included in the next release.

joevagyok’s picture

joevagyok commented
Assigned: atul_ghate » joevagyok
joevagyok’s picture

joevagyok commented
Issue summary: View changes
cedewey’s picture

cedewey
he/him
Primary language English
Location Denver, CO
commented
Status: Needs review » Reviewed & tested by the community

Us maintainers reviewed this and it works as expected. Thanks!

cedewey’s picture

cedewey
he/him
Primary language English
Location Denver, CO
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.