Problem/Motivation

Tests are failing on PHP 8.2. Let's see if we can fix that.

Postponed until laminas/laminas-feed is compatible with laminas/laminas-servicemanager 4.0.

The reason is that Drupal 10 requires psr/container ~2.0.2 and laminas/laminas-servicemanager 3.x requires prs/container ^1.0.
laminas/laminas-servicemanager 4.x is compatible with psr/container 2.0, but because laminas/laminas-feed isn't compatible with laminas/laminas-servicemanager 4.x yet, Feeds cannot be installed on Drupal 10 + PHP 8.2.

An issue is opened for laminas/laminas-feed, requesting compatibility with laminas/laminas-servicemanager 4.0:
https://github.com/laminas/laminas-feed/issues/75

Until that one is fixed, it looks like that there's nothing the Feeds team can do to make Feeds installable on Drupal 10 + PHP 8.2. It can be installed on Drupal 10 + PHP 8.1 and that's because laminas/laminas-servicemanager 3.15 is compatible with psr/container 2.0, but not with PHP 8.2. That looks like to be an error (as noted in https://github.com/laminas/laminas-servicemanager/pull/147), because laminas/laminas-servicemanager 3.16 isn't.

Possible workaround to install Feeds on PHP 8.2 now (not tested):

composer require drupal/feeds --ignore-platform-reqs

or

composer require drupal/feeds --ignore-platform-req=php

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork feeds-3325568

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

MegaChriz created an issue. See original summary.

MegaChriz opened merge request !100

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Active » Needs review
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

The PHP 8.2 failure in the test is a problem with core, I'll look for the relevant issue if not create it.

summit’s picture

summit commented

Hi,
Coming from https://www.drupal.org/project/feeds/issues/3344359
After your reply there I Installed latest .dev and stil seeing

Deprecated function: Creation of dynamic property Drupal\feeds\Form\MappingForm etc..

I thought I report it then here also.

Thanks for your reply in advance.

Greetings, Martijn

megachriz’s picture

megachriz
Primary language Dutch
commented

@Summit
You did apply the changes from this issue? The changes here are not merged to the latest dev yet.

summit’s picture

summit commented

Hi, is it my mistake that I do not see a patch to apply? Then sorry, I am not a programmer :)
Otherwise I will look how to apply the changes. Greetings,

megachriz’s picture

megachriz
Primary language Dutch
commented

See the plain diff link on the issue fork.

summit’s picture

summit commented

I do not have experience with plain diff links, but it works like composer with patch I presume. Just download
https://git.drupalcode.org/project/feeds/-/merge_requests/100.diff and use it as patch? If so I will try this. Greetings,

megachriz’s picture

megachriz
Primary language Dutch
commented

@Summit
Yes, for more information see https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr...

ptmkenny’s picture

ptmkenny commented

I've been using this MR for over three months now with PHP 8.2 and I haven't seen any deprecation-related errors in the logs.

megachriz’s picture

megachriz
Primary language Dutch
commented

Note: true PHP 8.2 support on Drupal 10 is not possible until the following issue is fixed:
https://github.com/laminas/laminas-servicemanager/issues/92

  • MegaChriz committed f22a3b3e on 8.x-3.x 
    Issue #3325568 by MegaChriz, ptmkenny: Added PHP 8.2 support.
megachriz’s picture

megachriz
Primary language Dutch
commented
Issue summary: View changes
Status: Needs review » Postponed

I've merged the code! Thanks for testing @ptmkenny

Marking this issue as postponed until https://github.com/laminas/laminas-servicemanager/issues/92 is fixed. Earlier, I think we cannot do anything to make Feeds installable through Composer without issues on Drupal 10 + PHP 8.2.

megachriz’s picture

megachriz
Primary language Dutch
commented
Issue summary: View changes

Closed #3372401: Problem laminas - installation is not possible as a duplicate.

cyu’s picture

cyu commented

With https://github.com/laminas/laminas-servicemanager/pull/188 merged into the 4.0 branch, can this be picked back up?

megachriz’s picture

megachriz
Primary language Dutch
commented

We are still out of luck here. While "laminas/laminas-servicemanager" now has a release candidate for its 4.0 branch, "laminas/laminas-feed" hasn't declared compatibility with it yet.

Maybe I should open an issue there.

megachriz’s picture

megachriz
Primary language Dutch
commented
Issue summary: View changes

I've opened an issue on laminas/laminas-feed: https://github.com/laminas/laminas-feed/issues/75.

A quick reply on that indicates that laminas/laminas-servicemanager first needs a full 4.0 release before laminas/laminas-feed can be made compatible with that version.

So I guess that people who would like to use Feeds on Drupal 10 + PHP 8.2 should test laminas/laminas-servicemanager 4.0.0-RC2.

MegaChriz opened merge request !125

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Postponed » Fixed

A new release of laminas/laminas-feed was made today where the dependency on laminas/laminas-servicemanager has been removed.

Now drupal/feeds can be installed on PHP 8.2! I just tested this manually, using composer require drupal/feeds on a Drupal 10.1.1 install. Also, now the Feeds tests pass on PHP 8.2!

So that makes this issue be fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.