This module has been designated "deprecated" by its maintainers. Sites using this module should switch to layout_builder_iframe_modal. Layout Builder iFrame Modal opens editing interfaces within a modal that uses the site's native administrative theme. It therefore provides a fail-proof look and feel that Media Library Theme Reset, which overrides front-end CSS, cannot.

Timeline

  • Until November 2023: Status is "Deprecated" but still "Supported"
  • After November 2023: Status becomes "Unsupported" but module is still available for use

In discovery during #3100124: Add support for Claro, the maintainers of Media Library Theme Reset concluded that there are now better solutions for the use case this module addresses, specifically Layout Builder Iframe Modal.

We wanted to prompt the community to begin switching to this better solution. So we removed the "supported" state from the module. This change began triggering email notifications on sites using the Update module for notifications, saying that the module was no longer supported. Confusion entailed. Some people thought this meant they had to change what they were using immediately, when in fact Media Library Theme Reset is still Drupal 8/9/10 compatible and can be installed on new and existing sites for the indefinite future, despite no longer being "supported." Others pointed out that these notifications could generate "noise" that would crowd out more important security notifications.

To remedy this, the module maintainers have decided to set the state back to "supported" and add a lifecycle key indicating that the module is deprecated. In November 2023, the module maintainers plan to set the state to "unsupported." Sites will still be able to use Media Library Theme Reset after November 2023, but the Update module will be more "noisy" about its status.

Tasks

1. Add a lifecycle key to this module, marking it as deprecated, linking to the indicated timeline for the module moving from "supported" to "unsupported" status.
2. Reach out to the maintainers of contrib modules who have indicated that Media Library Theme Reset should be used with their modules (Bootstrap Layout Builder, #3325151: Media Library Theme Reset not supported and Bootstrap Styles #3325150: Remove unsupported Media Library Theme Reset module), explaining that the module is deprecated, the timeline, and the proposed alternative.
3. After November 2023, set this module state to "unsupported" so that sites get more notification about the status change, but leave the lifecycle as "deprecated" so people can still install it on new and existing sites.

Comments

diwan_saich created an issue. See original summary.

mark_fullmer’s picture

Title: drupal 9 Not supported! Error Media Library Theme Reset 8.x-1.4 » "Not supported" message for Media Library Theme Reset 8.x-1.4
Issue tags: -Not supported! Error

Thank you for posting this. The maintainers of this module did, in fact, decide that Media Library Theme Reset should be considered outdated, since there are better options available.

See our message at the top of the project page, https://www.drupal.org/project/media_library_theme_reset

Marking the module as "Unsupported" does not make it uninstallable. It can be added to sites running Drupal 8, 9 or 10, using either Composer or as a direct download. It does add a message in the site interface presenting this module as "unsupported," which is the accurate status for this module.

If the recommended alternative, https://www.drupal.org/project/layout_builder_iframe_modal , does not meet a use case on your site, please let us know!

c.altosax’s picture

I understand that your desire with marking the project as "unsupported" was to notify site builders that they should switch to another module, such as layout builder iframe modal. I think that module would likely work for us, and I would switch over right away if it was simple to do so.

One concern to consider is that Drupal sites with Media Library Theme Reset installed now receive daily emails notifying them that they should immediately uninstall the module. Unfortunately, that is not possible for sites using modules that depend on this one. One such module is Bootstrap Styles, which is installed on 6600 sites. We are now depending on the Bootstrap Styles devs to update their module to remove this dependency, so we can uninstall your module and stop the daily emails. There may be other modules that are in a similar situation.

My concern is that the daily emails become noise, and can drown out actual security update notifications. They also sound a lot scarier than they really are, based on your promise to patch any "critical bugs." I hope that includes security vulnerabilities. My client receives the daily email alerts, and is a bit stressed about this. I'm sure he's not the only one.

Is there any other way to encourage site builders to switch modules while also avoiding these daily emails? It would be great to give other module developers time to update their modules as well.

yospyn’s picture

Second that, besides Bootstrap Styles there's also Bootstrap Layout Builder, which is used by over 6,000 sites (link is to new ticket related to this) and also uses Bootstrap Styles in combination. Because of their dependency to Media Library Theme Reset, we can't uninstall it and somehow switch to Layout Builder iFrame Modal.

The email alerts are annoying, but mostly just want to figure out a way to switch dependencies to Layout Builder iFrame Modal (if it will work with these Bootstrap modules), so MLTR can be uninstalled.

mark_fullmer’s picture

I [Media Library Theme Reset maintainer] hear your frustration! We certainly don't want to be contributing to noise that would cause people not to see important security updates. And as you point out, this module has a pretty high usage, so there are likely many sites with the "Update" module set up in such a way that they rely on daily emails from this blunt update notification tool for getting security updates.

For what it's worth, there are better ways of getting security updates. See https://www.drupal.org/security .

In addition to the news page and sub-tabs, all security announcements are posted to an email list. To subscribe to email: log in, go to your user profile page and subscribe to the security newsletter on the Edit » My newsletters tab.

You can also get rss feeds for core, contrib, or public service announcements or follow @drupalsecurity on Twitter.

Also, I might characterize this as a problem with the broadness of the Update module's notification tool, rather than a problem with Media Library Theme Reset's status.

As stated above, there is a value to the community to "encouraging site builders to switch modules," and setting this module back to "Supported" status would effectively make many site oblivious to that encouragement.

So, trying to problem solve a win-win situation:

1. Use Drupal's security notification email (above) and turn off emails from the "Update" module (https://www.drupal.org/forum/support/post-installation/2017-02-21/modify...).
2. For sites that have people who can write a minimal amount of code, they could implement an alter via https://api.drupal.org/api/drupal/core%21modules%21update%21update.api.p... to filter out Media Library Theme Reset.
3. Media Library Theme Reset could hook into Drupal's status report and put a warning there.

Feedback welcome!

mark_fullmer’s picture

I did a little digging around and found another tool we could use. Drupal now supports "lifecycle" status to convey the stability of a module/theme: https://www.drupal.org/node/3215042

We could add "deprecated" to Media Library Theme Reset. As a result "You can still install it, but there are warnings if it's installed on your site."

I'd be comfortable doing that and setting the project state back to "supported" for a period of months before we reintroduce the louder tool.

c.altosax’s picture

I like the idea of adding a warning to the status page, especially by setting the lifecycle status to “deprecated.”

You mentioned that site builders should be able to keep this module installed as they update to Drupal 10, so a visible but not frustratingly nagging notification sounds ideal.

As yospyn mentioned, there have already been issues filed with at least some of the dependent modules, so the devs are aware of what needs to be changed. I think that adding a warning to the status page would be enough of a reminder that that work needs to continue, while not driving people crazy while they wait for the fix.

In short, this sounds like a nice compromise.

astutonet’s picture

Hi guys. I've been following the discussion around this module and I think each case is a different case.

In my case, for example, one of the problems is that I'm working on migrating a site from D7 to D9 that hasn't even been published yet and I know it's going to give me a headache due to the Media Library Theme Reset (MLTR) module, as my project is almost ready to be published.

At the stage where the works are, it is impossible to start from zero, as this project has more than 1,500 published pages and there were many problems during the migration.

The biggest problem is that other modules depend on MLTR to work and therefore its replacement is not that simple.

"This module has been designated "outdated" by its maintainers. Sites using this module should switch to layout_builder_iframe_modal..."

Perhaps and if that possible, a good tutorial explaining to users how to make the switch and a greater interaction with the developers of other modules that depend on MLTR may be able to solve many problems and reduce the discussion around its "outdatedness", because on the module's page we can see that more than 10,000 sites use it.

This is my tip and request.

Webbeh’s picture

I did a little digging around and found another tool we could use. Drupal now supports "lifecycle" status to convey the stability of a module/theme: https://www.drupal.org/node/3215042

+1 to this, the usage of 'deprecated' as well as a timeline to moving to 'unsupported' would be an ideal situation for a module like this.

Webbeh’s picture

Title: "Not supported" message for Media Library Theme Reset 8.x-1.4 » Change lifecycle status from "Unsupported" to "Deprecated"
Assigned: diwan_saich » Unassigned
mark_fullmer’s picture

I've updated the issue description to capture our plan and will work on the code change next. Thanks, everyone!

mark_fullmer’s picture

Title: Change lifecycle status from "Unsupported" to "Deprecated" » Mark Media Library Theme Reset as "Deprecated"
Issue summary: View changes
mark_fullmer’s picture

Issue summary: View changes
mark_fullmer’s picture

Issue summary: View changes
mark_fullmer’s picture

Issue summary: View changes

  • mark_fullmer committed a49d6a6 on 8.x-1.x
    Issue #3325258 by mark_fullmer, diwan_saich, c.altosax, Webbeh,...
mark_fullmer’s picture

Category: Bug report » Task
c.altosax’s picture

This is fantastic, thank you Mark!

mark_fullmer’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.