Harmonize streamlines preprocessing of entities in Drupal before template rendering. It is a tool mainly for developers and was originally made to facilitate collaboration between back-end and front-end developers.

Project link

https://www.drupal.org/project/harmonize

Comments

ksere created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: [D9.3+ & D10] Harmonize » [3.x] Harmonize
Issue summary: View changes

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smother review.

To reviewers: Please read How to review security advisory coverage applications, What to cover in an application review, and Drupal.org security advisory coverage application workflow.

While this application is open, only the user who opened the application can make commits to the project used for the application.
Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

akshay.singh’s picture

akshay.singh commented

Hi there,
While reviewing your module for best practices and coding standards, I have found several issues.

FILE: /var/www/html/dContri/harmonize/harmonize.theme.inc
---------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------
 13 | ERROR | Doc comment for parameter &$variables does not match actual variable name $variables
 61 | ERROR | Doc comment for parameter &$variables does not match actual variable name $variables
---------------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/Form/Visualize/HarmonizeVisualizeForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 20 WARNINGS AFFECTING 20 LINES
------------------------------------------------------------------------------------------------------------------------------------------
  48 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  49 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  50 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  83 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  96 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 126 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 137 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 222 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 340 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 362 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 383 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 399 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 453 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 469 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 470 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 471 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 472 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 473 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 474 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 475 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/Form/HarmonizeSettingsForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
------------------------------------------------------------------------------------------------------------------------------------------
  53 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  54 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  61 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  62 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  69 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  70 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  90 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  91 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 106 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 107 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/Form/Entity/Style/StyleForm.php
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------
 173 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 181 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 212 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/Form/Cache/HarmonizeCacheConfigForm.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
 49 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 50 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 60 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 61 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/Form/EntityRules/HarmonizeEntityProcessingRulesForm.php
-------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
-------------------------------------------------------------------------------------------------
  46 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 172 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 173 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 341 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 365 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/Form/EntityRules/HarmonizeAddRulesForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES
------------------------------------------------------------------------------------------------------------------------------------------
  54 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  55 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  92 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  95 | WARNING | #description values usually have to run through t() for translation
 110 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 112 | WARNING | #description values usually have to run through t() for translation
 222 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 255 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/Form/EntityRules/HarmonizeEditRuleForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
------------------------------------------------------------------------------------------------------------------------------------------
  45 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  84 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  85 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  94 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  95 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 111 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 112 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 142 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 207 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/Form/EntityRules/HarmonizeDeleteRuleForm.php
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
 153 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/Service/Harmonize.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 193 | ERROR | Unknown type hint "mixed" found for $object
 193 | ERROR | Unknown type hint "mixed" found for $traceOutput
 231 | ERROR | Unknown type hint "mixed" found for $object
----------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/Service/FormTuner/EntityTypeEditFormTuner.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
 39 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 50 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 52 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 59 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 61 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/Service/FormTuner/EntityTypeViewDisplayFormTuner.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
 53 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/Service/Helpers.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------------
 240 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 428 | ERROR   | Unknown type hint "mixed" found for $var
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/Harmonizer/MenuHarmonizer/MenuHarmonizerInterface.php
-----------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------
 18 | ERROR | [x] Expected 1 blank line after function; 2 found
 21 | ERROR | [x] The closing brace for the interface must have an empty line before it
-----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/Harmonizer/Harmonizer.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 10 WARNINGS AFFECTING 11 LINES
------------------------------------------------------------------------------------------------------------------------------------------
 110 | ERROR   | Unknown type hint "mixed" found for $object
 128 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 131 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 142 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 148 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 155 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 159 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 389 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 392 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 395 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 407 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/Harmonizer/HarmonizerFactory.php
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
  41 | ERROR | Unknown type hint "mixed" found for $object
  93 | ERROR | Unknown type hint "mixed" found for $object
 104 | ERROR | Unknown type hint "mixed" found for $object
 126 | ERROR | Unknown type hint "mixed" found for $object
--------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/Harmonizer/MasterHarmonizerFactory.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 42 | ERROR | Unknown type hint "mixed" found for $object
--------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/Harmonizer/EntityHarmonizer/EntityFieldHarmonizer/EntityReferenceRevisionsEntityFieldHarmonizer.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------
 5 | WARNING | [x] Unused use statement
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/Harmonizer/EntityHarmonizer/EntityFieldHarmonizer/EntityReferenceEntityFieldHarmonizer.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 13 WARNINGS AFFECTING 11 LINES
------------------------------------------------------------------------------------------------------------------------------------------
 102 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 120 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 134 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 137 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 137 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 147 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 150 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 150 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 190 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 225 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 240 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 319 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 330 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/Harmonizer/EntityHarmonizer/FileEntityHarmonizer.php
----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
 73 | ERROR | Unknown type hint "mixed" found for $number
----------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/Harmonizer/EntityHarmonizer/ParagraphEntityHarmonizer.php
---------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
 5 | WARNING | [x] Unused use statement
 5 | ERROR   | [x] When importing a class with "use", do not include a leading \
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/Harmonizer/EntityHarmonizer/EntityHarmonizer.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 34 WARNINGS AFFECTING 34 LINES
------------------------------------------------------------------------------------------------------------------------------------------
 145 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 199 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 202 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 205 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 232 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 239 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 248 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 255 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 265 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 272 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 280 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 308 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 313 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 325 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 372 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 376 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 380 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 387 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 417 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 449 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 458 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 485 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 496 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 510 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 521 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 581 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 597 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 619 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 628 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 637 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 643 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 659 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 682 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 731 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/Harmonizer/RegionHarmonizer/RegionHarmonizer.php
------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------
 184 | ERROR | Unknown type hint "mixed" found for $element
------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/Harmonizer/HarmonizerInterface.php
----------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------
  63 | ERROR | Unknown type hint "mixed" found for $data
 167 | ERROR | Unknown type hint "mixed" found for $value
----------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/PluginManager/Refinery/RefinerInterface.php
-------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 1 LINE
-------------------------------------------------------------------------------------
 58 | ERROR | Unknown type hint "mixed" found for $consignment
 58 | ERROR | Unknown type hint "mixed" found for $harmony
 58 | ERROR | Unknown type hint "mixed" found for $object
-------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/PluginManager/Refinery/RefinerBase.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 98 | ERROR | Unknown type hint "mixed" found for $plugin_definition
--------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/EventSubscriber/RefineryEventSubscriber.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 9 WARNINGS AFFECTING 10 LINES
------------------------------------------------------------------------------------------------------------------------------------------
  33 | ERROR   | Missing @var tag in member variable comment
  74 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  91 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 101 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 108 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 119 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 127 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 131 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 144 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 171 | WARNING | Unused private method sortRefiners()
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/EventSubscriber/HarmonyEventSubscriber.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 9 WARNINGS AFFECTING 12 LINES
------------------------------------------------------------------------------------------------------------------------------------------
  67 | ERROR   | Missing @var tag in member variable comment
  72 | ERROR   | Missing @var tag in member variable comment
 117 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 121 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 139 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 154 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 177 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 197 | ERROR   | Unknown type hint "mixed" found for $consignment
 197 | ERROR   | Unknown type hint "mixed" found for $harmony
 225 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 231 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 235 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 240 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------


FILE: .../www/html/dContri/harmonize/modules/harmonize_examples/themes/custom/harmonize_examples_theme/harmonize_examples_theme.harmony.styles.yml
-----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/modules/harmonize_examples/themes/custom/harmonize_examples_theme/harmonize_examples.info.yml
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | "core_version_requirement" property is missing in the info.yml file
-----------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/modules/harmonize_examples/themes/custom/harmonize_examples_theme/harmonize_examples.theme
--------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
 5 | ERROR | Doc comment short description must start with a capital letter
--------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/modules/harmonize_examples/themes/custom/harmonize_examples_theme/harmony/README.md
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
 3 | WARNING | Line exceeds 80 characters; contains 81 characters
-------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/modules/harmonize_examples/harmonize_examples.info.yml
--------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------
 7 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/README.md
----------------------------------------------------------------------------------
FOUND 227 ERRORS AND 68 WARNINGS AFFECTING 173 LINES
----------------------------------------------------------------------------------
  18 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
  19 | WARNING | [ ] Line exceeds 80 characters; contains 120 characters
  22 | WARNING | [ ] Line exceeds 80 characters; contains 119 characters
  23 | WARNING | [ ] Line exceeds 80 characters; contains 117 characters
  26 | WARNING | [ ] Line exceeds 80 characters; contains 119 characters
  29 | WARNING | [ ] Line exceeds 80 characters; contains 125 characters
  30 | WARNING | [ ] Line exceeds 80 characters; contains 109 characters
  38 | WARNING | [ ] Line exceeds 80 characters; contains 114 characters
  39 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters
  40 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
  52 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
  53 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
  54 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters
  60 | WARNING | [ ] Line exceeds 80 characters; contains 109 characters
  61 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
  65 | WARNING | [ ] Line exceeds 80 characters; contains 117 characters
  66 | WARNING | [ ] Line exceeds 80 characters; contains 118 characters
  67 | WARNING | [ ] Line exceeds 80 characters; contains 122 characters
  68 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
  70 | WARNING | [ ] Line exceeds 80 characters; contains 120 characters
  71 | WARNING | [ ] Line exceeds 80 characters; contains 118 characters
  74 | WARNING | [ ] Line exceeds 80 characters; contains 96 characters
  78 | WARNING | [ ] Line exceeds 80 characters; contains 111 characters
  80 | WARNING | [ ] Line exceeds 80 characters; contains 120 characters
  84 | WARNING | [ ] Line exceeds 80 characters; contains 121 characters
  86 | WARNING | [ ] Line exceeds 80 characters; contains 139 characters
  92 | WARNING | [ ] Line exceeds 80 characters; contains 141 characters
  94 | WARNING | [ ] Line exceeds 80 characters; contains 171 characters
 111 | WARNING | [ ] Line exceeds 80 characters; contains 104 characters
 115 | WARNING | [ ] Line exceeds 80 characters; contains 116 characters
 117 | WARNING | [ ] Line exceeds 80 characters; contains 121 characters
 119 | WARNING | [ ] Line exceeds 80 characters; contains 111 characters
 121 | WARNING | [ ] Line exceeds 80 characters; contains 128 characters
 126 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters
 128 | WARNING | [ ] Line exceeds 80 characters; contains 120 characters
 129 | WARNING | [ ] Line exceeds 80 characters; contains 116 characters
 132 | WARNING | [ ] Line exceeds 80 characters; contains 101 characters
 134 | WARNING | [ ] Line exceeds 80 characters; contains 121 characters
 135 | WARNING | [ ] Line exceeds 80 characters; contains 119 characters
 142 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
 145 | WARNING | [ ] Line exceeds 80 characters; contains 106 characters
 152 | WARNING | [ ] Line exceeds 80 characters; contains 111 characters
 153 | WARNING | [ ] Line exceeds 80 characters; contains 151 characters
 162 | WARNING | [ ] Line exceeds 80 characters; contains 147 characters
 170 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters
 183 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters
 189 | WARNING | [ ] Line exceeds 80 characters; contains 121 characters
 192 | WARNING | [ ] Line exceeds 80 characters; contains 101 characters
 196 | WARNING | [ ] Line exceeds 80 characters; contains 117 characters
 198 | WARNING | [ ] Line exceeds 80 characters; contains 147 characters
 199 | WARNING | [ ] Line exceeds 80 characters; contains 131 characters
 211 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters
 217 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
 221 | WARNING | [ ] Line exceeds 80 characters; contains 130 characters
 222 | WARNING | [ ] Line exceeds 80 characters; contains 132 characters
 223 | WARNING | [ ] Line exceeds 80 characters; contains 92 characters
 225 | WARNING | [ ] Line exceeds 80 characters; contains 120 characters
 237 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters
 241 | WARNING | [ ] Line exceeds 80 characters; contains 100 characters
 245 | WARNING | [ ] Line exceeds 80 characters; contains 118 characters
 252 | WARNING | [ ] Line exceeds 80 characters; contains 120 characters
 270 | WARNING | [ ] Line exceeds 80 characters; contains 120 characters
 283 | WARNING | [ ] Line exceeds 80 characters; contains 133 characters
 286 | WARNING | [ ] Line exceeds 80 characters; contains 123 characters
 288 | WARNING | [ ] Line exceeds 80 characters; contains 142 characters
 295 | WARNING | [x] Unused use statement
 295 | ERROR   | [ ] USE declarations must go after the namespace declaration
 312 | WARNING | [ ] Line exceeds 80 characters; contains 107 characters
 313 | ERROR   | [x] Data types in @var tags need to be fully namespaced
 333 | ERROR   | [x] Concat operator must be surrounded by a single space
 333 | ERROR   | [x] Concat operator must be surrounded by a single space
 333 | ERROR   | [x] Concat operator must be surrounded by a single space
 343 | ERROR   | [x] Expected 1 blank line before function; 0 found
 348 | ERROR   | [x] Expected 1 blank line after function; 0 found
 351 | ERROR   | [x] Concat operator must be surrounded by a single space
 351 | ERROR   | [x] Concat operator must be surrounded by a single space
 351 | ERROR   | [x] Concat operator must be surrounded by a single space
 352 | ERROR   | [x] Concat operator must be surrounded by a single space
 352 | ERROR   | [x] Concat operator must be surrounded by a single space
 352 | ERROR   | [x] Concat operator must be surrounded by a single space
 353 | ERROR   | [x] Concat operator must be surrounded by a single space
 353 | ERROR   | [x] Concat operator must be surrounded by a single space
 353 | ERROR   | [x] Concat operator must be surrounded by a single space
 366 | ERROR   | [x] Expected 1 space before "/"; 0 found
 366 | ERROR   | [x] Expected 1 space after "/"; 0 found
 366 | ERROR   | [x] Expected 1 space before "/"; 0 found
 366 | ERROR   | [x] Expected 1 space after "/"; 0 found
 366 | ERROR   | [x] Expected 1 space before "/"; 0 found
 366 | ERROR   | [x] Expected 1 space after "/"; 0 found
 366 | ERROR   | [x] Expected 1 space before "/"; 0 found
 366 | ERROR   | [x] Expected 1 space after "/"; 0 found
 366 | ERROR   | [x] Expected 1 space before "/"; 0 found
 366 | ERROR   | [x] Expected 1 space after "/"; 0 found
 366 | ERROR   | [x] Concat operator must be surrounded by a single space
 371 | ERROR   | [x] Expected 1 space after "<"; 0 found
 371 | ERROR   | [x] Expected 1 space before "?"; 0 found
 371 | ERROR   | [x] Expected 1 space after "?"; 0 found
 375 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 377 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 390 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 392 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 397 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 398 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 4
 399 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 4
 400 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 402 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 403 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 405 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 406 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 408 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 408 | ERROR   | [x] Concat operator must be surrounded by a single space
 408 | ERROR   | [x] Concat operator must be surrounded by a single space
 410 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 410 | ERROR   | [x] Concat operator must be surrounded by a single space
 410 | ERROR   | [x] Concat operator must be surrounded by a single space
 410 | ERROR   | [x] Concat operator must be surrounded by a single space
 410 | ERROR   | [x] Concat operator must be surrounded by a single space
 411 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 413 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 415 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 416 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 418 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 420 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 420 | ERROR   | [x] Expected 1 space before "/"; 0 found
 420 | ERROR   | [x] Expected 1 space after "/"; 0 found
 420 | ERROR   | [x] Expected 1 space before "/"; 0 found
 420 | ERROR   | [x] Expected 1 space after "/"; 0 found
 420 | ERROR   | [x] Expected 1 space before "/"; 0 found
 420 | ERROR   | [x] Expected 1 space after "/"; 0 found
 420 | ERROR   | [x] Expected 1 space before "/"; 0 found
 420 | ERROR   | [x] Expected 1 space after "/"; 0 found
 420 | ERROR   | [x] Expected 1 space before "/"; 0 found
 420 | ERROR   | [x] Expected 1 space after "/"; 0 found
 420 | ERROR   | [x] Concat operator must be surrounded by a single space
 421 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 421 | ERROR   | [x] Expected 1 space before "/"; 0 found
 421 | ERROR   | [x] Expected 1 space after "/"; 0 found
 421 | ERROR   | [x] Expected 1 space before "/"; 0 found
 421 | ERROR   | [x] Expected 1 space after "/"; 0 found
 421 | ERROR   | [x] Concat operator must be surrounded by a single space
 421 | ERROR   | [x] Concat operator must be surrounded by a single space
 421 | ERROR   | [x] Concat operator must be surrounded by a single space
 421 | ERROR   | [x] Concat operator must be surrounded by a single space
 423 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 425 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 427 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 429 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 429 | ERROR   | [x] Space found before object operator
 429 | ERROR   | [x] Space found after object operator
 429 | ERROR   | [x] Space found before object operator
 429 | ERROR   | [x] Space found after object operator
 429 | ERROR   | [x] Space found before object operator
 429 | ERROR   | [x] Space found after object operator
 429 | ERROR   | [x] Space found before object operator
 429 | ERROR   | [x] Space found after object operator
 431 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 433 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 434 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 435 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 436 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 438 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 440 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 442 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 444 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 444 | ERROR   | [x] Concat operator must be surrounded by a single space
 444 | ERROR   | [x] Concat operator must be surrounded by a single space
 444 | ERROR   | [x] Concat operator must be surrounded by a single space
 445 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 445 | ERROR   | [x] Concat operator must be surrounded by a single space
 445 | ERROR   | [x] Concat operator must be surrounded by a single space
 445 | ERROR   | [x] Concat operator must be surrounded by a single space
 445 | ERROR   | [x] Concat operator must be surrounded by a single space
 446 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 448 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 450 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 452 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 453 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 455 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 455 | ERROR   | [x] Concat operator must be surrounded by a single space
 455 | ERROR   | [x] Concat operator must be surrounded by a single space
 455 | ERROR   | [x] Concat operator must be surrounded by a single space
 455 | ERROR   | [x] Concat operator must be surrounded by a single space
 457 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 459 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 461 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 463 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 465 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 467 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 467 | ERROR   | [x] Concat operator must be surrounded by a single space
 467 | ERROR   | [x] Concat operator must be surrounded by a single space
 467 | ERROR   | [x] Concat operator must be surrounded by a single space
 467 | ERROR   | [x] Concat operator must be surrounded by a single space
 467 | ERROR   | [x] Concat operator must be surrounded by a single space
 467 | ERROR   | [x] Concat operator must be surrounded by a single space
 467 | ERROR   | [x] Concat operator must be surrounded by a single space
 468 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 468 | ERROR   | [x] Concat operator must be surrounded by a single space
 468 | ERROR   | [x] Concat operator must be surrounded by a single space
 468 | ERROR   | [x] Concat operator must be surrounded by a single space
 469 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 469 | ERROR   | [x] Concat operator must be surrounded by a single space
 469 | ERROR   | [x] Concat operator must be surrounded by a single space
 469 | ERROR   | [x] Concat operator must be surrounded by a single space
 469 | ERROR   | [x] Concat operator must be surrounded by a single space
 471 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 473 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 475 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 477 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 479 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 479 | ERROR   | [x] Concat operator must be surrounded by a single space
 479 | ERROR   | [x] Concat operator must be surrounded by a single space
 481 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 483 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 484 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 484 | ERROR   | [x] Expected 1 space before "%"; 0 found
 484 | ERROR   | [x] Expected 1 space after "%"; 0 found
 485 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 487 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 488 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 490 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 492 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 492 | ERROR   | [x] Expected 1 space before "|"; 0 found
 492 | ERROR   | [x] Expected 1 space after "|"; 0 found
 494 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 495 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 497 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 498 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 498 | ERROR   | [x] Expected 1 space after "<"; 0 found
 498 | ERROR   | [x] Expected 1 space before ">"; 0 found
 499 | ERROR   | [x] Expected 1 space before "%"; 0 found
 499 | WARNING | [ ] Possible parse error: no opening parenthesis for FOR keyword
 499 | ERROR   | [x] Concat operator must be surrounded by a single space
 499 | ERROR   | [x] Expected 1 space before ":"; 0 found
 499 | ERROR   | [x] Expected 1 space after ":"; 0 found
 499 | ERROR   | [x] Expected 1 space after "%"; 0 found
 500 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 8
 500 | ERROR   | [x] Expected 1 space after "<"; 0 found
 501 | ERROR   | [x] Expected 1 space before "="; 0 found
 501 | ERROR   | [x] Expected 1 space after "="; 0 found
 502 | ERROR   | [x] Expected 1 space before "="; 0 found
 502 | ERROR   | [x] Expected 1 space after "="; 0 found
 503 | ERROR   | [x] Expected 1 space before "="; 0 found
 503 | ERROR   | [x] Expected 1 space after "="; 0 found
 504 | ERROR   | [x] Expected 1 space after "/"; 0 found
 504 | ERROR   | [x] Expected 1 space before ">"; 0 found
 505 | ERROR   | [x] Expected 1 space before "%"; 0 found
 505 | ERROR   | [x] Expected 1 space after "%"; 0 found
 506 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 506 | ERROR   | [x] Expected 1 space after "<"; 0 found
 506 | ERROR   | [x] Expected 1 space before "/"; 0 found
 506 | ERROR   | [x] Expected 1 space after "/"; 0 found
 506 | ERROR   | [x] Expected 1 space before ">"; 0 found
 507 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 509 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 511 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 513 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 515 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 515 | ERROR   | [x] Expected 1 space before "/"; 0 found
 515 | ERROR   | [x] Expected 1 space after "/"; 0 found
 515 | ERROR   | [x] Expected 1 space before "/"; 0 found
 515 | ERROR   | [x] Expected 1 space after "/"; 0 found
 515 | ERROR   | [x] Expected 1 space before "/"; 0 found
 515 | ERROR   | [x] Expected 1 space after "/"; 0 found
 515 | ERROR   | [x] Expected 1 space before "-"; 0 found
 515 | ERROR   | [x] Expected 1 space after "-"; 0 found
 517 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 519 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 520 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 521 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 522 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 524 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 525 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 527 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 529 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 531 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 533 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 534 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 536 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 538 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 538 | ERROR   | [x] Expected 1 space before "/"; 0 found
 538 | ERROR   | [x] Expected 1 space after "/"; 0 found
 538 | ERROR   | [x] Expected 1 space before "/"; 0 found
 538 | ERROR   | [x] Expected 1 space after "/"; 0 found
 538 | ERROR   | [x] Expected 1 space before "/"; 0 found
 538 | ERROR   | [x] Expected 1 space after "/"; 0 found
 540 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 542 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 544 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 544 | ERROR   | [x] Expected 1 space before "/"; 0 found
 544 | ERROR   | [x] Expected 1 space after "/"; 0 found
 544 | ERROR   | [x] Expected 1 space before "/"; 0 found
 544 | ERROR   | [x] Expected 1 space after "/"; 0 found
 544 | ERROR   | [x] Expected 1 space before "/"; 0 found
 544 | ERROR   | [x] Expected 1 space after "/"; 0 found
 546 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 227 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/harmonize.module
---------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 5 WARNINGS AFFECTING 10 LINES
---------------------------------------------------------------------------------------------------
  12 | WARNING | [x] Unused use statement
  39 | ERROR   | [x] Namespaced classes/interfaces/traits should be referenced with use statements
  76 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
  84 | ERROR   | [x] Inline control structures are not allowed
  92 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
  97 | WARNING | [ ] Line exceeds 80 characters; contains 101 characters
 115 | ERROR   | [x] Inline control structures are not allowed
 118 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
 128 | ERROR   | [x] Inline control structures are not allowed
 131 | ERROR   | [x] Inline control structures are not allowed
---------------------------------------------------------------------------------------------------
akshay.singh’s picture

akshay.singh commented
Status: Needs review » Needs work
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

The following seems a false positive. It's probably caused from the fact that the parameter is defined as array &$variables instead of &$variables as in template_preprocess_node().

13 | ERROR | Doc comment for parameter &$variables does not match actual variable name $variables
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

As a side note, check the email used from Git, because that isn't an email associated with your account. That's why the commits aren't associated with your account.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

When I run phpcs --standard=DrupalPractice on the 3.x branch, I get the following report.

FILE: src/Harmonizer/EntityHarmonizer/EntityHarmonizer.php
FOUND 0 ERRORS AND 34 WARNINGS AFFECTING 34 LINES
 145 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 199 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 202 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 205 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 232 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 239 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 248 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 255 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 265 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 272 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 280 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 308 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 313 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 325 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 372 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 376 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 380 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 387 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 417 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 449 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 458 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 485 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 496 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 510 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 521 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 581 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 597 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 619 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 628 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 637 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 643 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 659 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 682 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 731 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead


FILE: ...luno/SSDPR/Patches/harmonize_3x/src/Harmonizer/EntityHarmonizer/EntityFieldHarmonizer/EntityReferenceEntityFieldHarmonizer.php
FOUND 0 ERRORS AND 13 WARNINGS AFFECTING 11 LINES
 102 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 120 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 134 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 137 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 137 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 147 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 150 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 150 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 190 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 225 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 240 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 319 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 330 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead


FILE: src/Harmonizer/Harmonizer.php
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
 128 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 131 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 142 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 148 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 155 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 159 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 389 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 392 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 395 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 407 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead


FILE: src/EventSubscriber/HarmonyEventSubscriber.php
FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
 117 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 121 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 139 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 154 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 177 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 225 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 231 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 235 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 240 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead


FILE: src/EventSubscriber/RefineryEventSubscriber.php
FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
  74 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
  91 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 101 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 108 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 119 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 127 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 131 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 144 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 171 | WARNING | Unused private method sortRefiners()


FILE: src/Service/Helpers.php
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
 240 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead


FILE: src/Service/FormTuner/EntityTypeEditFormTuner.php
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
 39 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 50 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 52 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 59 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 61 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead


FILE: src/Service/FormTuner/EntityTypeViewDisplayFormTuner.php
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
 53 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead


FILE: src/Form/Cache/HarmonizeCacheConfigForm.php
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
 49 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 50 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 60 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 61 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead


FILE: src/Form/HarmonizeSettingsForm.php
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
  53 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
  54 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
  61 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
  62 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
  69 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
  70 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
  90 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
  91 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 106 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 107 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead


FILE: src/Form/Visualize/HarmonizeVisualizeForm.php
FOUND 0 ERRORS AND 20 WARNINGS AFFECTING 20 LINES
  48 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  49 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  50 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  83 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
  96 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 126 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 137 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 222 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 340 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 362 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 383 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 399 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 453 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 469 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 470 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 471 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 472 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 473 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 474 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 475 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead


FILE: src/Form/EntityRules/HarmonizeDeleteRuleForm.php
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
 153 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead


FILE: src/Form/EntityRules/HarmonizeEntityProcessingRulesForm.php
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
  46 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 172 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 173 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 341 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 365 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead


FILE: src/Form/EntityRules/HarmonizeAddRulesForm.php
FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES
  54 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  55 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  92 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
  95 | WARNING | #description values usually have to run through t() for translation
 110 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 112 | WARNING | #description values usually have to run through t() for translation
 222 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 255 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead


FILE: src/Form/EntityRules/HarmonizeEditRuleForm.php
FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
  45 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  84 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
  85 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
  94 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
  95 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 111 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 112 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 142 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 207 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead


FILE: src/Form/Entity/Style/StyleForm.php
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
 173 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 181 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 212 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

Running the same command for the 2.x branch, I get this report.

FILE: src/Harmonizer/MenuHarmonizer/MenuHarmonizer.php
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
 72 | WARNING | Unused variable $id.


FILE: src/Harmonizer/EntityHarmonizer/EntityHarmonizer.php
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
 161 | WARNING | Unused variable $key.


FILE: ...un/media/kiamlaluno/SSDPR/Patches/harmonize_2x/src/Harmonizer/EntityHarmonizer/EntityFieldHarmonizer/EntityFieldHarmonizer.php
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
 164 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead


FILE: src/EventSubscriber/RefineryEventSubscriber.php
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
 116 | WARNING | Unused private method sortRefiners()


FILE: src/PluginManager/Refinery/RefineryDiscovery.php
FOUND 1 ERROR AFFECTING 1 LINE
 55 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes
    |       | option.


FILE: src/Service/Harmonize.php
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
 228 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead


FILE: src/Service/Helpers.php
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
 138 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead


FILE: src/Form/HarmonizeDataConfigForm.php
FOUND 0 ERRORS AND 14 WARNINGS AFFECTING 14 LINES
 108 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 109 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 123 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 127 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 135 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 139 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 170 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 183 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 234 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 235 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 245 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 271 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 272 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 282 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead


FILE: src/Form/HarmonizeSettingsForm.php
FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES
 49 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 50 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 61 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 62 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 72 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 73 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 83 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 84 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead


FILE: src/Form/HarmonizeCacheConfigForm.php
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
 47 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 48 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 59 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 60 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead


FILE: src/Plugin/views/style/HarmonizeStyle.php
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
 99 | WARNING | Unused variable $row_index.
ksere’s picture

ksere commented

Hello, thank you! I will take a look at this today and get back to you.

ksere’s picture

ksere commented

Hello!

Seems like my PHPStorm PHPCS was set to 'Drupal' instead of 'DrupalPractice'.

I'll be doing a full review of the standards and I'll push the update through, along with double-checking the email associated.

Should have an update by the end of today!

ksere’s picture

ksere commented
Status: Needs work » Needs review

Hello,

I've gone through and cleaned up the errors provided. Mainly the use of $this-t() has been addressed.

I've also removed usage of the mixed type across the code. This seems to have been throwing warnings.

Changes were brought to both 2.x and 3.x.

akshay.singh’s picture

akshay.singh commented

Hey @ksere,
Still, there are some minor issues left. Please check

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml harmonize/

FILE: /var/www/html/dContri/harmonize/src/Service/Harmonize.php
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
 195 | ERROR | [ ] Unknown type hint "mixed" found for $object
 195 | ERROR | [ ] Unknown type hint "mixed" found for $traceOutput
 230 | ERROR | [x] Data types in @return tags need to be fully namespaced
 233 | ERROR | [ ] Unknown type hint "mixed" found for $object
--------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/Harmonizer/Harmonizer.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 39 | ERROR | Missing member variable doc comment
----------------------------------------------------------------------


FILE: ...nizer/EntityHarmonizer/EntityFieldHarmonizer/FileEntityFieldHarmonizer.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 42 | WARNING | [x] '@todo - is this safe? we should validate that this can't
    |         |     lead to infinity loops.' should match the format '@todo Fix
    |         |     problem X here.'
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...dContri/harmonize/src/Harmonizer/EntityHarmonizer/FileEntityHarmonizer.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 73 | ERROR | Unknown type hint "mixed" found for $number
--------------------------------------------------------------------------------


FILE: ...ri/harmonize/src/Harmonizer/EntityHarmonizer/EntityHarmonizerInterface.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 42 | ERROR | [x] Expected
    |       |     "\Drupal\harmonize\Harmonizer\HarmonizerInterface|string|array|null"
    |       |     but found
    |       |     "\Drupal\harmonize\Harmonizer\HarmonizerInterface|string|array|NULL"
    |       |     for function return type
--------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/src/PluginManager/Refinery/RefinerBase.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 98 | ERROR | Unknown type hint "mixed" found for $plugin_definition
--------------------------------------------------------------------------------


FILE: .../www/html/dContri/harmonize/src/EventSubscriber/HarmonyEventSubscriber.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------------
 203 | ERROR | Unknown type hint "mixed" found for $consignment
 203 | ERROR | Unknown type hint "mixed" found for $harmony
--------------------------------------------------------------------------------


FILE: ...l/dContri/harmonize/modules/harmonize_examples/harmonize_examples.info.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 7 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------


FILE: /var/www/html/dContri/harmonize/README.md
--------------------------------------------------------------------------------
FOUND 245 ERRORS AND 13 WARNINGS AFFECTING 136 LINES
--------------------------------------------------------------------------------
  43 | WARNING | [ ] Line exceeds 80 characters; contains 114 characters
  44 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters
  45 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
  57 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
  58 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
  59 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters
 178 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters
 179 | WARNING | [ ] Line exceeds 80 characters; contains 151 characters
 188 | WARNING | [ ] Line exceeds 80 characters; contains 147 characters
 245 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters
 339 | WARNING | [x] Unused use statement
 339 | ERROR   | [ ] USE declarations must go after the namespace declaration
 356 | WARNING | [ ] Line exceeds 80 characters; contains 107 characters
 357 | ERROR   | [x] Data types in @var tags need to be fully namespaced
 379 | ERROR   | [x] Concat operator must be surrounded by a single space
 379 | ERROR   | [x] Concat operator must be surrounded by a single space
 380 | ERROR   | [x] Concat operator must be surrounded by a single space
 391 | ERROR   | [x] Expected 1 blank line before function; 0 found
 396 | ERROR   | [x] Expected 1 blank line after function; 0 found
 400 | ERROR   | [x] Concat operator must be surrounded by a single space
 400 | ERROR   | [x] Concat operator must be surrounded by a single space
 400 | ERROR   | [x] Concat operator must be surrounded by a single space
 402 | ERROR   | [x] Concat operator must be surrounded by a single space
 402 | ERROR   | [x] Concat operator must be surrounded by a single space
 402 | ERROR   | [x] Concat operator must be surrounded by a single space
 402 | ERROR   | [x] Concat operator must be surrounded by a single space
 402 | ERROR   | [x] Concat operator must be surrounded by a single space
 402 | ERROR   | [x] Concat operator must be surrounded by a single space
 420 | ERROR   | [x] Expected 1 space before "/"; 0 found
 420 | ERROR   | [x] Expected 1 space after "/"; 0 found
 420 | ERROR   | [x] Expected 1 space before "/"; 0 found
 420 | ERROR   | [x] Expected 1 space after "/"; 0 found
 420 | ERROR   | [x] Expected 1 space before "/"; 0 found
 420 | ERROR   | [x] Expected 1 space after "/"; 0 found
 420 | ERROR   | [x] Expected 1 space before "/"; 0 found
 420 | ERROR   | [x] Expected 1 space after "/"; 0 found
 420 | ERROR   | [x] Expected 1 space before "/"; 0 found
 420 | ERROR   | [x] Expected 1 space after "/"; 0 found
 420 | ERROR   | [x] Concat operator must be surrounded by a single space
 425 | ERROR   | [x] Expected 1 space after "<"; 0 found
 425 | ERROR   | [x] Expected 1 space before "?"; 0 found
 425 | ERROR   | [x] Expected 1 space after "?"; 0 found
 429 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 431 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 444 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 446 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 451 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 452 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 4
 453 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 4
 454 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 456 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 457 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 459 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 460 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 461 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 462 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 464 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 465 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 465 | ERROR   | [x] Concat operator must be surrounded by a single space
 465 | ERROR   | [x] Concat operator must be surrounded by a single space
 467 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 467 | ERROR   | [x] Concat operator must be surrounded by a single space
 468 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 468 | ERROR   | [x] Concat operator must be surrounded by a single space
 468 | ERROR   | [x] Concat operator must be surrounded by a single space
 468 | ERROR   | [x] Concat operator must be surrounded by a single space
 470 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 472 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 473 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 475 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 477 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 477 | ERROR   | [x] Expected 1 space before "/"; 0 found
 477 | ERROR   | [x] Expected 1 space after "/"; 0 found
 477 | ERROR   | [x] Expected 1 space before "/"; 0 found
 477 | ERROR   | [x] Expected 1 space after "/"; 0 found
 477 | ERROR   | [x] Expected 1 space before "/"; 0 found
 477 | ERROR   | [x] Expected 1 space after "/"; 0 found
 477 | ERROR   | [x] Expected 1 space before "/"; 0 found
 477 | ERROR   | [x] Expected 1 space after "/"; 0 found
 477 | ERROR   | [x] Expected 1 space before "/"; 0 found
 477 | ERROR   | [x] Expected 1 space after "/"; 0 found
 477 | ERROR   | [x] Concat operator must be surrounded by a single space
 478 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 478 | ERROR   | [x] Expected 1 space before "/"; 0 found
 478 | ERROR   | [x] Expected 1 space after "/"; 0 found
 478 | ERROR   | [x] Expected 1 space before "/"; 0 found
 478 | ERROR   | [x] Expected 1 space after "/"; 0 found
 478 | ERROR   | [x] Concat operator must be surrounded by a single space
 478 | ERROR   | [x] Concat operator must be surrounded by a single space
 478 | ERROR   | [x] Concat operator must be surrounded by a single space
 478 | ERROR   | [x] Concat operator must be surrounded by a single space
 480 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 482 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 484 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 485 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 487 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 487 | ERROR   | [x] Space found before object operator
 487 | ERROR   | [x] Space found after object operator
 487 | ERROR   | [x] Space found before object operator
 487 | ERROR   | [x] Space found after object operator
 487 | ERROR   | [x] Space found before object operator
 487 | ERROR   | [x] Space found after object operator
 487 | ERROR   | [x] Space found before object operator
 487 | ERROR   | [x] Space found after object operator
 489 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 491 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 492 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 493 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 494 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 496 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 498 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 499 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 501 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 502 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 504 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 504 | ERROR   | [x] Concat operator must be surrounded by a single space
 504 | ERROR   | [x] Concat operator must be surrounded by a single space
 504 | ERROR   | [x] Concat operator must be surrounded by a single space
 505 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 505 | ERROR   | [x] Concat operator must be surrounded by a single space
 505 | ERROR   | [x] Concat operator must be surrounded by a single space
 505 | ERROR   | [x] Concat operator must be surrounded by a single space
 505 | ERROR   | [x] Concat operator must be surrounded by a single space
 506 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 508 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 510 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 512 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 513 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 515 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 515 | ERROR   | [x] Concat operator must be surrounded by a single space
 515 | ERROR   | [x] Concat operator must be surrounded by a single space
 515 | ERROR   | [x] Concat operator must be surrounded by a single space
 515 | ERROR   | [x] Concat operator must be surrounded by a single space
 516 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 518 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 520 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 521 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 523 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 525 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 527 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 528 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 530 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 530 | ERROR   | [x] Concat operator must be surrounded by a single space
 530 | ERROR   | [x] Concat operator must be surrounded by a single space
 530 | ERROR   | [x] Concat operator must be surrounded by a single space
 530 | ERROR   | [x] Concat operator must be surrounded by a single space
 531 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 531 | ERROR   | [x] Concat operator must be surrounded by a single space
 531 | ERROR   | [x] Concat operator must be surrounded by a single space
 531 | ERROR   | [x] Concat operator must be surrounded by a single space
 532 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 533 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 533 | ERROR   | [x] Concat operator must be surrounded by a single space
 533 | ERROR   | [x] Concat operator must be surrounded by a single space
 533 | ERROR   | [x] Concat operator must be surrounded by a single space
 534 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 534 | ERROR   | [x] Concat operator must be surrounded by a single space
 534 | ERROR   | [x] Concat operator must be surrounded by a single space
 534 | ERROR   | [x] Concat operator must be surrounded by a single space
 534 | ERROR   | [x] Concat operator must be surrounded by a single space
 536 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 538 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 540 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 542 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 543 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 545 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 545 | ERROR   | [x] Concat operator must be surrounded by a single space
 545 | ERROR   | [x] Concat operator must be surrounded by a single space
 546 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 548 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 549 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 551 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 552 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 552 | ERROR   | [x] Expected 1 space before "%"; 0 found
 552 | ERROR   | [x] Expected 1 space after "%"; 0 found
 553 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 555 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 556 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 557 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 559 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 561 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 561 | ERROR   | [x] Expected 1 space before "|"; 0 found
 561 | ERROR   | [x] Expected 1 space after "|"; 0 found
 562 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 564 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 565 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 567 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 568 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 568 | ERROR   | [x] Expected 1 space after "<"; 0 found
 568 | ERROR   | [x] Expected 1 space before ">"; 0 found
 569 | ERROR   | [x] Expected 1 space before "%"; 0 found
 569 | WARNING | [ ] Possible parse error: no opening parenthesis for FOR
     |         |     keyword
 569 | ERROR   | [x] Concat operator must be surrounded by a single space
 569 | ERROR   | [x] Expected 1 space before ":"; 0 found
 569 | ERROR   | [x] Expected 1 space after ":"; 0 found
 569 | ERROR   | [x] Expected 1 space after "%"; 0 found
 570 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 8
 570 | ERROR   | [x] Expected 1 space after "<"; 0 found
 571 | ERROR   | [x] Expected 1 space before "="; 0 found
 571 | ERROR   | [x] Expected 1 space after "="; 0 found
 572 | ERROR   | [x] Expected 1 space before "="; 0 found
 572 | ERROR   | [x] Expected 1 space after "="; 0 found
 573 | ERROR   | [x] Expected 1 space before "="; 0 found
 573 | ERROR   | [x] Expected 1 space after "="; 0 found
 574 | ERROR   | [x] Expected 1 space after "/"; 0 found
 574 | ERROR   | [x] Expected 1 space before ">"; 0 found
 575 | ERROR   | [x] Expected 1 space before "%"; 0 found
 575 | ERROR   | [x] Expected 1 space after "%"; 0 found
 576 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 576 | ERROR   | [x] Expected 1 space after "<"; 0 found
 576 | ERROR   | [x] Expected 1 space before "/"; 0 found
 576 | ERROR   | [x] Expected 1 space after "/"; 0 found
 576 | ERROR   | [x] Expected 1 space before ">"; 0 found
 577 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 579 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 581 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 583 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 585 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 585 | ERROR   | [x] Expected 1 space before "/"; 0 found
 585 | ERROR   | [x] Expected 1 space after "/"; 0 found
 585 | ERROR   | [x] Expected 1 space before "/"; 0 found
 585 | ERROR   | [x] Expected 1 space after "/"; 0 found
 585 | ERROR   | [x] Expected 1 space before "/"; 0 found
 585 | ERROR   | [x] Expected 1 space after "/"; 0 found
 585 | ERROR   | [x] Expected 1 space before "-"; 0 found
 585 | ERROR   | [x] Expected 1 space after "-"; 0 found
 587 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 588 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 590 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 591 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 592 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 593 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 595 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 596 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 597 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 599 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 601 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 603 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 605 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 606 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 608 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 610 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 610 | ERROR   | [x] Expected 1 space before "/"; 0 found
 610 | ERROR   | [x] Expected 1 space after "/"; 0 found
 610 | ERROR   | [x] Expected 1 space before "/"; 0 found
 610 | ERROR   | [x] Expected 1 space after "/"; 0 found
 610 | ERROR   | [x] Expected 1 space before "/"; 0 found
 610 | ERROR   | [x] Expected 1 space after "/"; 0 found
 612 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 614 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 616 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 616 | ERROR   | [x] Expected 1 space before "/"; 0 found
 616 | ERROR   | [x] Expected 1 space after "/"; 0 found
 616 | ERROR   | [x] Expected 1 space before "/"; 0 found
 616 | ERROR   | [x] Expected 1 space after "/"; 0 found
 616 | ERROR   | [x] Expected 1 space before "/"; 0 found
 616 | ERROR   | [x] Expected 1 space after "/"; 0 found
 618 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
--------------------------------------------------------------------------------
akshay.singh’s picture

akshay.singh commented
Status: Needs review » Needs work
ksere’s picture

ksere commented

Hello Akshay,

Thank you for reviewing this again. I've gone through and made adjustments for the last fixes.

As for the README.md ones, they do not seem to be accurate as they seem to be applying PHP rules to the .md file. I've ignored most of those for now, but at least made sure the line lengths were below 80 in the README.

ksere’s picture

ksere commented
Status: Needs work » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the Slack #contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the reviewers.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed
ksere’s picture

ksere commented

Thank you very much Akshay Singh & apaderno!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.