Problem/Motivation

Webform currently provides its own special handling for image_captcha_refresh from the CAPTCHA module.

We're currently working on CAPTCHA 2.x and much of the structure will change. Testing it with Webform showed us, that there may be conflicts with the custom implementation in Webform. Furthermore the additional "image_captcha_refresh" implementation in Webform won't be required anymore.

So I'd strongly suggest removing this special handling from Webform and display the selected captcha as-is.

MR follows.

Steps to reproduce

Proposed resolution

Remove the webform custom image_captcha_refresh entirely.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#10 webform_3323387_6.1.x_image_captcha_refresh.patch2.78 KBsc_cojocari

Issue fork webform-3323387

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Anybody created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Active » Needs review

Anybody opened merge request !250

jrockowitz’s picture

jrockowitz commented

Do we need to do CAPTCHA version detection and keep the code around for CAPTCHA 8.x-1.x.

jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thanks @jrockowitz and sorry for the missing reply, I didn't see the notification. I think it's just fine as CAPTCHA 2.x will be the default for Drupal 10 and stability will grow with the removal of this special handling.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

alesr’s picture

alesr commented

Will this fix be also in Webform 6.1.x (stable) because right now it's only in 6.2.x (beta)?

sc_cojocari’s picture

sc_cojocari commented
StatusFileSize
new webform_3323387_6.1.x_image_captcha_refresh.patch2.78 KB

Just in case you need a patch for 6.1.x (tested with 6.1.7)