Problem/Motivation

During last weeks accessibility walkthrough, @mgifford and @mherchel helped identify several contrast issues and how to test for them in Chrome - regardless of OS! No more Virtualbox/Parallels (for this at least).

Steps to reproduce

In the Chrome developer tools render config, test with just forced colors

Then test with forced colors + light/dark schemes

Here's an example of a problem that surfaces with a dark scheme

Here's an example of a problem that surfaces with a light scheme

Bugs addressed in this issue:
Icons:

  1. Advanced filters icon
  2. Close icon on applied filter pills
  3. List and Grid icons
  4. Project usage icon on module page for dark mode
  5. Project usage icon in list view for light color scheme
  6. Copy icons on instructional modal in light color scheme

Borders:

  1. Filter button
  2. Applied filter pills
  3. List and Grid buttons
  4. Categories on module page
  5. Categories on module cards
  6. Commands in instructional modal

Proposed resolution

  • Assess all the forced colors related issues and determine if it's better to address them all here, or turn this issue into a meta and move problems to dedicated issues
  • If this doesn't become a meta issue, each find should be added to the issue summary so we don't need to sift through comments to find the contrast bugs that need addressing.
  • Look for missing/obscured borders, text icons and other image use essential to understanding the UI.
  • Use the forced colors media query for changes that should only be present in forced colors mode
  • Check out how the forced color media query is used in Claro and Olivero for ways of addressing the issue
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

bnjmnm created an issue. See original summary.

srishtiiee made their first commit to this issue’s fork.

srishtiiee’s picture

Issue summary: View changes
srishtiiee’s picture

Status: Active » Needs review
StatusFileSize
new178.61 KB
new183.15 KB
new94.66 KB
new96.66 KB

Fixed a couple of forced color contrast bugs:

narendrar’s picture

Status: Needs review » Needs work

Changes looks good to me.
Found some more places where this can be implemented:

  • Popup: Border, copy icon, cross button etc in light scheme
  • Active Installs icon on list view in dark scheme
  • May be a border to category on list/grid
srishtiiee’s picture

Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new208.99 KB
new207.58 KB

Addressed all the remaining bugs.

narendrar’s picture

Status: Needs review » Reviewed & tested by the community

Changes looks good to me. Marked issue as RTBC.

bnjmnm’s picture

Status: Reviewed & tested by the community » Needs work

Left a few comments in the MR.

Also, lets do the filter: invert(1); treatment to the "Covered by Drupal Security Team" icons on the projects and in the advanced filter area.

It would be nice to do something similar with the magnifying glass icon in the search input, but it would require a different solution due to the img src being svg. If a solution isn't quickly apparent, file a follow up and mention it here as I don't want to delay the good additions here.

srishtiiee’s picture

Status: Needs work » Needs review
bnjmnm’s picture

StatusFileSize
new308.95 KB

I took care of the search and security coverage icons.

This means I'm not able to RTBC/commit, but due to Chrome's recent improvements with forced colors testing (documented in the issue summary), this should be a pretty easy review for anyone. All the CSS changes from @srishtiiee are something I'd commit, so a reviewer could largely focus on the dark color scheme detection and the image swaps that result from it.

narendrar’s picture

StatusFileSize
new638.1 KB

Found couple of issues/suggestions:
Issue

1. Text size is different
2. Buttons can have borders to give better visibility.

narendrar’s picture

Status: Needs review » Needs work
bnjmnm’s picture

Issue tags: +core-mvp
srishtiiee’s picture

Status: Needs work » Needs review
narendrar’s picture

Status: Needs review » Reviewed & tested by the community

Changes looks good to me. Marking as RTBC.

tim.plunkett made their first commit to this issue’s fork.

tim.plunkett’s picture

Status: Reviewed & tested by the community » Fixed

Merged, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.