Problem/Motivation

node-sass and libsass are not supported any more. We should switch for Dart SASS library. We need this also for later Bootstrap 5 update.

Read more about differences from Ruby SASS in this doc.

Issue fork bs_base-3320888

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pivica created an issue. See original summary.

pivica’s picture

pivica commented
Version: 8.x-1.x-dev » 2.x-dev

Moving to next major version.

pivica’s picture

pivica commented
Issue summary: View changes
dhruv.mittal’s picture

dhruv.mittal commented
Assigned: Unassigned » dhruv.mittal

dhruv.mittal opened merge request !13

dhruv.mittal’s picture

dhruv.mittal commented
Assigned: dhruv.mittal » Unassigned
Status: Active » Needs review

Kindly review :)

pivica’s picture

pivica commented
Status: Needs review » Needs work

@dhruv.mittal thx for trying to contribute to this issue, but i am afraid this is much more complicated then just changing package in package.json and in related gulp JS files.

At a very minimum we need:
- All SASS code needs to be updated and deprecated SASS code fixed. Check related Bootstrap 5 issue for more details on this https://github.com/twbs/bootstrap/pull/41112
- We need theme update function that will update child themes automatically - similar what you did in MR
- A lot of testing and maybe couple of more things we will for sure discover along the way ;)

pivica’s picture

pivica commented
Status: Needs work » Postponed

So Bootstrap 6 dev plan is out (https://github.com/twbs/bootstrap/pull/41236) and the plan is that Bootstrap 6 will switch to Dart SASS which probably means we can't switch for now and we will do this when we start porting to Bootstrap 6.