Problem/Motivation

If a post update throws an exception it's not properly reported and instead you see an error about severity_level as a placeholder. This became more of problem when #3295625: Remove deprecated code from FormattableMarkup landed.

Steps to reproduce

Trigger an exception in a post update. The update system should report the error gracefully.

Proposed resolution

Unset severity_level. This is major bug because the update system is not reporting the correct error.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

N/a

CommentFileSizeAuthor
#2 3295625-2.patch3.92 KBalexpott
#2 3295625-2-test-only.patch3.32 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Active » Needs review
FileSize
3295625-2-test-only.patch3.32 KB
3295625-2.patch3.92 KB

The last submitted patch, 2: 3295625-2-test-only.patch, failed testing. View results

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Needs review » Reviewed & tested by the community

Looks tidy and the test fails nicely.

  • larowlan committed fc983ed on 10.0.x 
    Issue #3319839 by alexpott: Exceptions in post updates are very broken...
  • larowlan committed 07f87ca on 10.1.x
    Issue #3319839 by alexpott: Exceptions in post updates are very broken...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Version: 10.0.x-dev » 9.5.x-dev

Committed to 10.1.x and 10.0.x

Moving to 9.5.x for a test run

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 9.5.x-dev » 9.4.x-dev

Let's see if this passes on 9.4.x and 9.5.x - the patch is not so important because in 9.x we emit a silenced deprecation that no one sees but it would be nice to not do that.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented

yes, it passed

  • larowlan committed 5c55f15 on 9.5.x 
    Issue #3319839 by alexpott: Exceptions in post updates are very broken...

  • larowlan committed 4dd0b45 on 9.4.x 
    Issue #3319839 by alexpott: Exceptions in post updates are very broken...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

Cherry picked to 9.5.x and 9.4.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.