Problem/Motivation

FormattableMarkup issues a deprecation when a key without a placeholder prefix is found.

This code did not use the standard deprecation format so we did not find it until now.

Steps to reproduce

Proposed resolution

Convert the deprecation to a warning, which is the same behaviour as other invalid placeholders.

Remaining tasks

Consider if we should backport the deprecation notice to the standard format.

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3295625-2.patch2.45 KBlongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 3295625-2.patch2.45 KB
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Nice find, patch looks exactly right to me.

  • 1ac261d committed on 10.0.x 
    Issue #3295625 by longwave, catch: Remove deprecated code from...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Superb, commited, thanks!

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: +Deprecation Removal
catch’s picture

catch
he/him
Primary language English
commented
Status: Fixed » Reviewed & tested by the community

@Gábor Hojtsy looks like the 10.1.x commit is missing.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Version: 10.0.x-dev » 10.1.x-dev
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

  • alexpott committed a2ec6b9 on 10.1.x 
    Issue #3295625 by longwave, catch: Remove deprecated code from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.