Using Drupal on PHP 8.1, the module throws this warning.

Deprecated function: stristr(): Passing null to parameter #1 ($haystack) of type string is deprecated in Drupal\amp\Service\AMPService::isDevPage() (line 173 of modules/contrib/amp/src/Service/AMPService.php).

That happens because AMPService::isDevPage() calls \Drupal::request()->getQueryString() and passes the values it return to stristr(), which doesn't accept anymore a NULL value, on PHP 8.1.

Before calling stristr(), the code needs to check the passed argument isn't NULL or cast that value to a string. In this way, NULL will be converted to an empty string.

CommentFileSizeAuthor
amp-stristr-warning-patch.diff596 bytescasivaagustin

Comments

casivaagustin created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Deprecated function: stristr(): Passing null to parameter #1 ($haystack) of type string is deprecated in Drupal\amp\Service\AMPService->isDevPage() » stristr(): Passing null to parameter #1 ($haystack) of type string is deprecated in Drupal\amp\Service\AMPService::isDevPage()
Priority: Minor » Normal
Issue tags: +PHP 8.1
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Needs review
ankitjhakal’s picture

ankitjhakal commented
Assigned: Unassigned » ankitjhakal
ankitjhakal’s picture

ankitjhakal commented
Assigned: ankitjhakal » Unassigned
Status: Needs review » Reviewed & tested by the community

Tested and applied patch on local. Issue is resolved after applying patch. So changing status of it.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Duplicate of #3263406: stristr(): Passing null to parameter #1 ($haystack) of type string is deprecated in Drupal\amp\Service\AMPService::isDevPage()

The other patch has strange formatting though, so maybe makes more sense to commit this.

pick_d’s picture

pick_d commented

Patch works for me as well (Drupal 9.5.1, PHP 8.1.13).

Thanks a lot.

littlepixiez’s picture

littlepixiez commented

Patch works for me! Fixes deprecation errors on PHP 8.1. Thanks @casivaagustin

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented

Patch works for me as well, it would be great to be merged, thank you.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented

I just created (then closed) a duplicate of this #3356049: stristr(): Passing null to parameter #1 ($haystack) of type string is deprecated in AMPService::isDevPage(). I am facing this issue as well.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Reviewed & tested by the community » Fixed

Thanks everyone!

Committed to 8.x-3.x. I'll tag a release shortly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.