Problem/Motivation
Remove the active composer metadata fixture files in\Drupal\Tests\automatic_updates_extensions\Functional\UpdaterFormTest
Steps to reproduce
Proposed resolution
Remaining tasks
Create a follow-up to remove the staged composer fixture files. This is a bit more tricky than kernel tests so it should be its own issue
User interface changes
API changes
Data model changes
Issue fork automatic_updates-3318625
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
kunal.sachdev commentedComment #4
tedbowworked with @kunal.sachdev on this. Functional tests are more complicated because you have to get the stage directory after the update has been stages so you can use
\Drupal\Tests\package_manager\Traits\FixtureUtilityTrait::modifyPackageon the stage directory.Since we don't know the stage id we can't claim the stage to get the directory.
We will probably need a helper function like
getSTageDirectoryfor functional test or we could make a wrapper aroundmodifyPackagelikemodifyStagedPackagethat would take care of this for usComment #5
wim leersComment #6
kunal.sachdev commentedI have some test failures locally with error :
Comment #7
wim leers#6:
Comment #8
tedbowthis is a related problem we have to fix first #3320487: fake-site fixtures has invalid packages in composer files
Comment #9
wim leersComment #10
kunal.sachdev commentedBlocker is in
Comment #11
kunal.sachdev commentedComment #12
wim leers1 review, needs input from @tedbow.
Comment #13
wim leersComment #14
tedbowComment #15
tedbowFor MR comments,
Comment #16
tedbowComment #17
kunal.sachdev commentedComment #18
wim leersGreen and the last 3 commits look clean … I can't review this quite yet, so assigning to @tedbow 😊
Comment #19
tedbow@kunal.sachdev getting close. thanks
Also we still have a follow-up issue that we need to make from the summary, I think. If it already exists lets add it as a related issue and remove the "Needs follow-up" tag
Comment #20
kunal.sachdev commentedComment #21
kunal.sachdev commentedComment #22
tedbow@kunal.sachdev thanks for creating #3321904: Remove automatic_updates_extensions/tests/fixtures/stage_composer in favor of using StageFixtureManipulator
I think this looks good. I am glad the test changes are pretty small but it still lets us get rid of a bunch of fixture files. I think this speak the value of the `addPackage`, `modifyPackage` and `removePackage` methods 🎉.
Once we do #3321236: Add actual project folders in \Drupal\Tests\package_manager\Traits\FixtureUtilityTrait::addPackage I think we would also be able remove the fixture folders such as
automatic_updates_extensions/tests/fixtures/two_projects/web/projects/aaa_automatic_updates_testComment #23
wim leersIndeed,
+31 -161is a nice diff stat 👏Comment #25
tedbowComment #27
tedbow