Coding standards [#3317635]

Problem/Motivation

FILE: /var/www/html/drupal_cms/drupal9/web/modules/contrib/viewsreference/js/viewsreference.js
----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
 37 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal_cms/drupal9/web/modules/contrib/viewsreference/src/Plugin/Field/FieldType/ViewsReferenceItem.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
---------------------------------------------------------------------------------------------------------------------------
  93 | ERROR | [x] Use null coalesce operator instead of ternary operator.
 112 | ERROR | [x] Use null coalesce operator instead of ternary operator.
 113 | ERROR | [x] Use null coalesce operator instead of ternary operator.
 114 | ERROR | [x] Use null coalesce operator instead of ternary operator.
---------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal_cms/drupal9/web/modules/contrib/viewsreference/src/Plugin/Field/FieldFormatter/ViewsReferenceFieldFormatter.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
 98 | WARNING | Line exceeds 80 characters; contains 88 characters
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal_cms/drupal9/web/modules/contrib/viewsreference/src/Plugin/Field/ViewsReferenceFieldItemList.php
--------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------
 69 | ERROR | Missing parameter type
--------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal_cms/drupal9/web/modules/contrib/viewsreference/src/Plugin/Field/FieldWidget/ViewsReferenceWidget.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
 39 | ERROR | [x] Use null coalesce operator instead of ternary operator.
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal_cms/drupal9/web/modules/contrib/viewsreference/src/Plugin/Field/FieldWidget/ViewsReferenceTrait.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------------
  56 | ERROR | [x] Use null coalesce operator instead of ternary operator.
 323 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
 405 | ERROR | [x] Use null coalesce operator instead of ternary operator.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------

Time: 215ms; Memory: 14MB

Comment	File	Size	Author
#6	Screenshot from 2022-10-26 15-12-49.png	80.44 KB	erikaagp
#2	coding-standards-3317635-2.patch	5.84 KB	prasaddeole

Issue fork viewsreference-3317635

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3317635-coding-standards changes, plain diff MR !22
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

26 October 2022 at 17:30

PrasadDeole created an issue. See original summary.

Comment #2

prasaddeole commented 26 October 2022 at 17:39

Status	File	Size
new	coding-standards-3317635-2.patch	5.84 KB

Comment #3

prasaddeole commented 26 October 2022 at 17:39

Assigned:	prasaddeole	» Unassigned
Status:	Active	» Needs review

Comment #4

erikaagp commented 26 October 2022 at 19:29

Assigned:

Unassigned

» erikaagp

I'll review it

Comment #5

26 October 2022 at 21:39

erikaagp opened merge request !22

Comment #6

erikaagp commented 26 October 2022 at 21:42

Status	File	Size
new	Screenshot from 2022-10-26 15-12-49.png	80.44 KB

Hi, I applied the patch successfully but I realized that module had more phpcs errors on it (screenshot), so I fixed them. I pushed the changes with a commit on the branch. Needs another review now.