Much like the other issues related to running an audit and getting a fatal error on an unknown column, this time related to the 'heading field' module.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | site_audit-heading_field-3316625-2.patch | 1.15 KB | tanc |
Issue fork site_audit-3316625
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
tancPatch also added as duplicate of the merge request
Comment #4
the_g_bomb commentedI have applied this patch as a part of a patch cocktail to get site_audit working locally.
I can confirm this patch resolves the issue we were experiencing.
### Environment:
- Drupal 10.4.8
- Site Audit: 4.0.x-dev
- Heading field module installed
### Error Before Patch:
### After Applying Patch:
The error is resolved. The patch correctly handles the custom column structure of the heading field type (`field_heading_text` instead of `field_heading_value`).
The site_audit command now runs without database errors when scanning paragraphs with heading fields.
Comment #7
froboy@the_g_bomb I'd rather not add module-specific fixes here, especially for relatively small modules (Heading reports <3000 sites). I generated this more generalized fix. I don't totally understand it all yet, but on testing, it was able to resolve all of the db errors with the Heading module installed.
Could you please review https://git.drupalcode.org/project/site_audit/-/merge_requests/23 and let me know if it seems reasonable?
Thanks.
Comment #8
the_g_bomb commentedI have applied the new patch from MR23
Thanks to the closing of all the tickets recently, I no longer need a patch cocktail to get site_audit working locally.
I can confirm this patch resolves the issue we were experiencing.
### Environment:
- Drupal 10.5.8
- Site Audit: 4.1.2 (strangely the dev release has not updated)
- Heading field module installed
### Error Before Patch:
### After Applying Patch:
The error is resolved. The patch correctly handles the custom column structure of the heading field type (`field_heading_text` instead of `field_heading_value`).
The site_audit command now runs without database errors when scanning paragraphs with heading fields and there are no new error messages in the log file.
Thank you.
I much prefer the generic fix rather than the module specific one.
Comment #9
the_g_bomb commentedFYI, I was also able to remove a custom patch I had created for a custom field that was causing a similar "unknown column" error.
Comment #11
froboy@the_g_bomb thanks so much for your breadcrumbs of patches and your review!