Problem/Motivation

Currently when Project Browser is added there is the following local task order:

single module page screenshot with the local tasks list update browse and uninstall

We wondered if that is the right and to be desired logical order. While writing up the issue I’ve noticed that the position could vary.
While with the automatic updates extensions module installed Browse gets moved one position to the right
“single
On one installation Browse is positioned even at the end of the local task list (not sure which patch and or installed other module lead into that):
“single

For the record the issue was identified and initially discussed during #3312892: Drupal Usability Meeting 2022-10-07. The issue has a link to the recording of the meeting. The attendees were @AaronMcHale, @benjifisher, @narendraR, @rkoller, @shaal, @simohell, @srishtiiee, @Utkarsh_33, and @worldlinemine.

Steps to reproduce

Go to /admin/modules/browse or /admin/modules

Proposed resolution

Make the local task Browse the default task. Make List the second tab.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rkoller created an issue. See original summary.

rkoller’s picture

Issue summary: View changes
rkoller’s picture

Issue summary: View changes
rkoller’s picture

Issue summary: View changes
rkoller’s picture

Issue summary: View changes
StatusFileSize
new12.63 KB
rkoller’s picture

Issue summary: View changes
rkoller’s picture

srishtiiee made their first commit to this issue’s fork.

srishtiiee’s picture

Status: Active » Needs review

narendraR made their first commit to this issue’s fork.

rkoller’s picture

Apologies for the late reply. But each time I tried applying the patch i ran into caching issues not directly related with the patch but with my local environment it looks like meanwhile. :(
But after manually testing another time tonight I can confirm that the position of the browse tab and its weight value get correctly updated. i leave the issue at needs review cuz i havent done a code review of the test code.

narendrar’s picture

StatusFileSize
new9.45 KB

Changes pushed in MR. Also patch attached with the changes. Done on wrong issue. Apologies.

narendrar’s picture

bnjmnm made their first commit to this issue’s fork.

tim.plunkett’s picture

Issue tags: +core-post-mvp
phenaproxima’s picture

Status: Needs review » Needs work

Found a few relatively minor code quality things, and one bigger concern that I'm thinking can result in false positives if we don't correct it. Otherwise, looks straightforward to me.

chrisfromredfin’s picture

chrisfromredfin’s picture

Status: Needs work » Needs review

I believe all the threads are resolved except for that huge one where I pasted the entire markup (RIP your scrollbar). Anyone want to take another look?

chrisfromredfin’s picture

Issue summary: View changes
Status: Needs review » Needs work

Following the usability study done with University of Minnesota, it became clear that browse really must be the FIRST tab, and therefore the default task for "Extend."

I've updated the proposed resolution. Marking "Needs Work"

chrisfromredfin’s picture

Status: Needs work » Fixed

Merged this because it gets us started and gets us a test, and we still need to discuss whether or not to make it the default tab (I believe so, but there is not consensus). There is another issue for that, so I like leaving this one.

Tests did fail, but they were separate fails on flaky FunctionalJavascript tests.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.