Problem/Motivation

phpstan/phpstan 1.8.7 and above throw errors when running analysis, https://github.com/phpstan/phpstan/issues/8139

Proposed resolution

Introduce a conflict section in composer.json for phpstan >=1.8.7 until an upstream fix is released

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3314774-2.patch868 bytesspokje

Comments

mondrake created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3314774-2.patch868 bytes
spokje’s picture

spokje
Primary language Dutch
commented
Related issues: +#3314873: Remove PHPStan conflict section in composer.json, bump to ^1.8.10

Opened #3314873: Remove PHPStan conflict section in composer.json, bump to ^1.8.10 as a follow-up to update/remove the conflict section when a fix lands in a PHPStan release.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review

Test failures are all unrelated JS failures (at least that's what it looks like me), triggered retest.

More importantly: PHP 8.1 & MySQL 5.7 updated deps now doesn't return Custom Commands Failed before even starting any tests.

Status: Needs review » Needs work

The last submitted patch, 2: 3314774-2.patch, failed testing. View results

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review

TestBot is having a bad JS-test day apparently. Not wasting any more test-cycles on it.

Status: Needs review » Needs work

The last submitted patch, 2: 3314774-2.patch, failed testing. View results

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review

Frequent random JS test failures => back to NR

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

RTBC, given https://www.drupal.org/pift-ci-job/2498079 and local testing that produced the same failed result with PHPStan 1.8.8.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3314774-2.patch, failed testing. View results

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Reviewed & tested by the community

  • catch committed 1c9b2a6 on 10.0.x 
    Issue #3314774 by Spokje, mondrake: Skip PHPStan >=1.8.7

(cherry picked...
  • catch committed fb72360 on 10.1.x
    Issue #3314774 by Spokje, mondrake: Skip PHPStan >=1.8.7
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x and cherry-picked to 10.0.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.