Problem/Motivation

phpstan/phpstan 1.8.3 is out https://github.com/phpstan/phpstan/releases/tag/1.8.3

However, it looks like it brings a major degradation of performance - Drupal core tests run PHPStan 1.8.2 in 2' 10" (approx), while the run on 1.8.3 takes around 40' --> 20x slower

Not sure whether to report upstream - there's a https://github.com/phpstan/phpstan/issues/7581 [Poor performance in recent versions] already open.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3307361

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue summary: View changes
mondrake’s picture

mondrake
Location 🇮🇹
commented

Not only Drupal: https://github.com/phpstan/phpstan/issues/7894#issuecomment-1234665865

mondrake’s picture

mondrake
Location 🇮🇹
commented
Title: Update (?) PHPStan to 1.8.3 » Skip PHPStan 1.8.3
Assigned: Unassigned » mondrake
Priority: Normal » Major

and https://github.com/phpstan/phpstan/issues/7903

I think it's better skip 1.8.3 and wait for a release that addresses the performance regressions.

Right now the 'updated deps' tests would fail - both because actually there are errors reported by the PHPStan run, and in fact even if that was clear, the job will timeout.

mondrake opened merge request !2728

mondrake’s picture

mondrake
Location 🇮🇹
commented
Assigned: mondrake » Unassigned
Status: Active » Needs review
spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community

- Green TestBot on both updated and "normal" dependencies.
- Explanation on why we want to skip phpstan/phpstan 1.8.3 are clear (at least to me)
- Code changes make sense

RTBC for me.

  • catch committed 41cd758 on 10.1.x 
    Issue #3307361 by mondrake, Spokje: Skip PHPStan 1.8.3
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x and cherry-picked to 10.0.x, thanks!

  • catch committed 6033e1d on 10.0.x 
    Issue #3307361 by mondrake, Spokje: Skip PHPStan 1.8.3

(cherry picked...
mondrake’s picture

mondrake
Location 🇮🇹
commented

Filed #3307789: Update to PHPStan 1.8.4.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mondrake closed merge request !2728