Problem/Motivation

In #3314774: Skip PHPStan >=1.8.7 we added a conflict-section to our root composer.json to skip PHPStan versions >=1.8.7.

We need to update that section to close that open-ended section when a fix in PHPStan lands in a release.

Issue in PHPStan: https://github.com/phpstan/phpstan/issues/8139
Issue in PHPStan dependency Roave/BetterReflection: https://github.com/Roave/BetterReflection/issues/1278

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#5 3314873-5.patch3.96 KBspokje

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Postponed

Postponing on new release of PHPStan.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Postponed » Active

The upstreams should have fixed this in PHPStan 1.8.10 https://github.com/phpstan/phpstan/issues/8139#issuecomment-1280497560.

Once that release is available we can try to bump to it and see if that fits.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Title: [PP-1 Upstream] Update/remove PHPStan conflict section in composer.json » [PP-1 Upstream] Update/remove PHPStan conflict section in composer.json, bump to ^1.8.10
spokje’s picture

spokje
Primary language Dutch
commented
Title: [PP-1 Upstream] Update/remove PHPStan conflict section in composer.json, bump to ^1.8.10 » Update/remove PHPStan conflict section in composer.json, bump to ^1.8.10
StatusFileSize
new 3314873-5.patch3.96 KB

PHPStan released 1.8.10 https://github.com/phpstan/phpstan/releases/tag/1.8.10

Let's see how it works out for us.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Reviewed & tested by the community

Net of the javascript test fails, this looks fine now, PHPStan is no longer failing.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Title: Update/remove PHPStan conflict section in composer.json, bump to ^1.8.10 » Remove PHPStan conflict section in composer.json, bump to ^1.8.10

  • catch committed a0788db on 10.0.x 
    Issue #3314873 by Spokje, mondrake: Remove PHPStan conflict section in...
  • catch committed 26a4075 on 10.1.x
    Issue #3314873 by Spokje, mondrake: Remove PHPStan conflict section in...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x and 10.0.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.