Coding standard issue fixes.

CommentFileSizeAuthor
#4 gdpr-3314425-coding-standards-issue-fixes-4.patch34.45 KBrajeshreeputra
#3 gdpr-3314425-coding-standards-issue-fixes-3.patch0 bytesrajeshreeputra

Issue fork gdpr-3314425

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Rajeshreeputra created an issue. See original summary.

Rajeshreeputra opened merge request !18

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Status: Active » Needs review
StatusFileSize
new gdpr-3314425-coding-standards-issue-fixes-3.patch0 bytes
rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
StatusFileSize
new gdpr-3314425-coding-standards-issue-fixes-4.patch34.45 KB
ankitv18’s picture

ankitv18 commented
Assigned: rajeshreeputra » ankitv18
ankitv18’s picture

ankitv18 commented
Status: Needs review » Needs work

Reviewed and found under sub-module gdpr_tasks/ gdpr_tasks.module still having phpcs issue 

 14 | WARNING | [x] Unused use statement
 68 | ERROR   | [ ] All functions defined in a module file must be prefixed with the module's name, found "gdpr_fields_entity_type_alter" but expected "gdpr_tasks_gdpr_fields_entity_type_alter"
ankitv18’s picture

ankitv18 commented
Assigned: ankitv18 » Unassigned
Status: Needs work » Needs review
ankitv18’s picture

ankitv18 commented
Status: Needs review » Reviewed & tested by the community

Reviewed and it didn't get any warning or notice in phpcs command, hence moving into RTBC

  • Rajeshreeputra committed e05f7108 on 3.0.x 
    Issue #3314425 by Rajeshreeputra, ankitv18: Coding standards Issue fixes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed
rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Status: Fixed » Closed (fixed)

Thank you for working, merged, release to follow shortly!