CommentFileSizeAuthor
#10 3313162-10.patch378 bytesgauravvvv
#8 Screenshot 2022-10-19 at 4.14.56 PM.png439.65 KBsandeepmahlawat
#6 diff-3313162-6.txt962 bytesmanojkumar_97
#6 3313162-6.patch962 bytesmanojkumar_97
#6 After Patch.png26.82 KBmanojkumar_97
#3 search_bar_not_clickable-3313162-3.patch944 bytesatul_ghate
Screenshot 2022-10-03 at 11.50.03 AM.png803.36 KBsandeepmahlawat

Comments

SandeepMahlawat created an issue. See original summary.

atul_ghate’s picture

atul_ghate commented
Issue summary: View changes

Hi i will work this issue.

atul_ghate’s picture

atul_ghate commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new search_bar_not_clickable-3313162-3.patch944 bytes

Here is a patch for your review. If there are any changes that need to be made, let me know.

jatingupta40’s picture

jatingupta40 commented
Assigned: Unassigned » jatingupta40

I will review this patch.

manojkumar_97’s picture

manojkumar_97 commented
Assigned: jatingupta40 » manojkumar_97
Status: Needs review » Needs work
manojkumar_97’s picture

manojkumar_97 commented
Assigned: manojkumar_97 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new After Patch.png26.82 KB
new 3313162-6.patch962 bytes
new diff-3313162-6.txt962 bytes

I applied patch #3. They clickable when message are showing on top once refresh page the search input not clickable. I have created new patch for this.
After Patch Apply:
after patch

jatingupta40’s picture

jatingupta40 commented

Also @manojkumar_97 in the future, please check if someone is already assigned to the issue or not, as if someone else is already assigned to the issue, then don't work on that issue.
Also now you need to add a semi-colon after the z-index.

The patch #3 and #6, both are same.

Thank You.

sandeepmahlawat’s picture

sandeepmahlawat commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot 2022-10-19 at 4.14.56 PM.png439.65 KB

Hi Manoj your patch #6 is working fine for me.

gauravvvv’s picture

gauravvvv commented
Version: 9.1.x-dev » 10.1.x-dev
gauravvvv’s picture

gauravvvv commented
StatusFileSize
new 3313162-10.patch378 bytes

Do not use ID selector when we have class selector available. Attached the updated patch.

  • Gauravvv authored 93fa4dd0 on 10.1.x 
    Issue #3313162 by manojkumar_97, Gauravvv, atul ghate, SandeepMahlawat:...
gauravvvv’s picture

gauravvvv commented
Status: Reviewed & tested by the community » Fixed

Committed 93fa4dd0 and pushed to 10.1.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Lyhtande’s picture

Lyhtande commented

I am on Zircon 10.1.x-dev but can't apply 3313162-6.patch nor 3313162-10.patch - obviously I already have the changes. But I still can't write into the search field.

Update: The issue was my mistake, the post can be deleted.