Follow-up to #3299853: Apply #[\AllowDynamicProperties] attribute to base classes to make PHP 8.2 log size sane from #3309748-4: Define missing object properties on non-testing classes for PHP 8.2
We can apply 4 attributes to prevent contrib testing bloating CI logs
Lots of plugins has undefined properties so having #[\AllowDynamicProperties] can help it silence out
Apply #[\AllowDynamicProperties] attribute to following classes and add follow-ups to #3299855: [META] Get rid of #[\AllowDynamicProperties] attribute
- discuss possible side effects (for ex. inability to get deprecation warnings because attribute applied to base class)
- agree and commit with backport to 9.5
no
no
no
no
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 3311383-7.patch | 2.55 KB | andypost |
| #7 | interdiff.txt | 365 bytes | andypost |
Comments
Comment #2
andypostMaybe
ViewsExecutablecould be fixed but not sure we allowed to add properties at the stage of releaseComment #3
catchI think this is a good idea, we can try to remove it again later.
One thing I'm not clear on - is this attribute 'permanent' in PHP or is it also going to be deprecated later? But if we have an active effort to clean this up over time that might not matter by the time we get there anyway.
Comment #4
andypostLet's see how many pass with this way
Comment #5
berdir> One thing I'm not clear on - is this attribute 'permanent' in PHP or is it also going to be deprecated later? But if we have an active effort to clean this up over time that might not matter by the time we get there anyway.
Replied in slack already, I think that's an open discussion, original plan was AFAIK that it is is a BC layer. We do already have a meta issue to remove them.
Comment #6
andypostLet's see how many failures will left after #3309748-11: Define missing object properties on non-testing classes for PHP 8.2
Very probably we should add attribute to ViewUI as well
Comment #7
andypostAdded and follow-up is #3311442: Only set defined properties on config entities in EntityForm::copyFormValuesToEntity
Comment #8
berdirSeems sensible. The follow-up is #3299855: [META] Get rid of #[\AllowDynamicProperties] attribute.
Comment #10
catchCommitted/pushed to 10.1.x and cherry-picked back through to 9.5.x, thanks!
Comment #12
andypostThank you! The last tricky fix left #3311562: Set sqlQuery in Entity\Query\Sql Condition classes on own class
Comment #13
berdir> through to 9.5.x
Note that we actually didn't backport a bunch of PHP 8.2 changes, including specifically #3299853: Apply #[\AllowDynamicProperties] attribute to base classes to make PHP 8.2 log size sane, not sure if you want to do that still.
Comment #14
catchI had sort of given up on PHP 8.2 compatibility in Drupal 9, but it is looking like we might get close, if not all the way there. Went ahead and backported that one.