Fix "Unknown themes: classy" error in the tests

I have Uploaded the patch. Please review it

Thanks @Anchal_gupta for providing a patch!

1. +++ b/tests/src/FunctionalJavascript/MediaLibraryTest.php
   @@ -27,7 +27,7 @@ class MediaLibraryTest extends WebDriverTestBase {
   -  protected $defaultTheme = 'classy';
   +  protected $defaultTheme = 'stark';
   
   +++ b/tests/src/FunctionalJavascript/MediaTest.php
   @@ -79,7 +79,7 @@ class MediaTest extends WebDriverTestBase {
   -  protected $defaultTheme = 'classy';
   +  protected $defaultTheme = 'stark';
   

   So Stark is the best choice for the long term, but it won't have the classes these tests are relying on. It would be better to use starterkit_theme which will be closer to what was in Classy, just to do as little work as possible since this module will be end-of-life in about a year.

2. +++ b/tests/src/FunctionalJavascript/MediaTest.php
   @@ -242,18 +242,18 @@ class MediaTest extends WebDriverTestBase {
   -    // Test when using the classy theme, an additional class is added in
   -    // classy/templates/content/media-embed-error.html.twig.
   -    $this->assertTrue($this->container->get('theme_installer')->install(['classy']));
   +    // Test when using stark theme, an additional class is added in
   ...
   +    $this->assertTrue($this->container->get('theme_installer')->install(['stark']));
        $this->config('system.theme')
   -      ->set('default', 'classy')
   +      ->set('default', 'stark')
   

   This especially is not going to work. @sorabh.v6 observed that this file no longer exists in Classy, and it definitely never existed in Stark in the first place.

Adding credit for @sorabh.v6 for investigating the media-embed-error.html.twig issue.

media-embed-error.css also does not exist in starterkit_theme. We may need to copy that file and associated assets into this module. We may also need to create an entirely new test theme fixture to test this behavior, or just remove that whole part of the test as something we no longer support. I'll consult the maintainers.

Could we add Classy as a dev dependency for this module to make the tests pass?

Could we add Classy as a dev dependency for this module to make the tests pass?

+1 — that is the simplest possible solution IMHO 🤓

Actually, can we first try switching to starterkit_theme instead?

That worked fine for Quick Edit in #3309243: New test failures on D10: `UnknownExtensionException: Unknown themes: classy` 😊

Depending on classy is much more less likely to run into problems in future. Starterkit theme is likely to change in future and could lead into the tests breaking.

It looks like Classy is also broken because it should have a dependency on drupal/stable . 🤦‍♂️

#3311528: HEAD broken because of missing dependency on Stable has been resolved.

Still lots of new failures for #13 even after #3311528: HEAD broken because of missing dependency on Stable (although only 6 instead of 12):

Exception: Warning: scandir(core/assets/vendor/ckeditor/lang): Failed to open directory: No such file or directory

I very much prefer my patch from #11 though, because then we don't have to deal with maintaining a composer.json file and how the d.o composer facade interacts with that. So re-testing that.

Closed #3311028: 1.0.x Branch Tests Failing as a duplicate of this.

Only now do I see what a collossally stupid mistake I made in #11 🙈

Ah, I bet that #22 doesn't work simply because we need d.o's composer facade to make it be respected by Drupal CI… 😬

So … going ahead and committing #22, then I should start seeing the 6 failures that @lauriii's #13 saw.

I think #22 doesn't work because modules can't add dependencies on themes 🤓

#27: argh. What a mess. Can't wait for Drupal to have way better validation, because it'd massively improve the DX.
What you say makes sense, sadly, @lauriii 😞

… although https://www.drupal.org/pift-ci-job/2485695 did work just fine 🤓

Like I said … a huge mess 🙈

The remaining 2 failures are both in \Drupal\Tests\ckeditor\Kernel\CKEditorTest, and they can only be tested in Drupal <10.0, because they depended on extensions providing explicit CKEditor 4 support.

To clarify

because they depended on extensions providing explicit CKEditor 4 support.

→ the changes in #3270438: Remove CKEditor 4 from core make it impossible to test this in Drupal >=10

And that's … reasonable. 👍

The remaining failures are not happening on 10.0.x, only on 9.4.x and 9.5.x. This is due to #3306545: Replace ckeditor with ckeditor5 in the 9.4.x database dumps in Drupal 10.0.x & 10.1.x having modified the update path fixtures.

I've tested this fix locally, should work for all branches 😊