Problem/Motivation

Branch tests are failing for 1.0.x: https://www.drupal.org/pift-ci-job/2473687.
Setting to critical per Critical Bugs.

Proposed resolution

Fix tests

Remaining tasks

MR with passing tests

User interface changes

None

API changes

None

Data model changes

None

Issue fork ckeditor-3311028

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Chris Burge created an issue. See original summary.

Chris Burge opened merge request !9

chris burge’s picture

chris burge commented
Status: Active » Needs work

It looks like it'll be necessary to add a composer.json file: Add a composer.json file:

Here are some reasons for creating a composer.json file:

  • A contributed module that depends on other modules/packages and has automated tests that run on the DrupalCI environment must have a composer.json that expresses the dependencies. Tests of merge requests on the module will fail without a composer.json file, as will tests of patches that change the dependencies.
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

That's not true — see for example https://git.drupalcode.org/project/quickedit/-/commit/00a8710d0796286626... which installed a contrib module too, without adding a composer.json file.

The difference here is that it's a theme, that's not being installed explicitly.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Closed (duplicate)
Related issues: +#3311367: Fix "Unknown themes: classy" error in the tests

This has more progress in #3311367: Fix "Unknown themes: classy" error in the tests, so closing this as a duplicate. No worries; will credit you there! :)