Problem/Motivation

Just to make it a bit nicer

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 3308527.patch526 byteslarowlan
#3 3308527.patch614 byteslarowlan
#2 3308527.patch0 byteslarowlan

Comments

larowlan created an issue. See original summary.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Needs review
StatusFileSize
new 3308527.patch0 bytes
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
StatusFileSize
new 3308527.patch614 bytes
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
StatusFileSize
new 3308527.patch526 bytes
dpi’s picture

dpi
Location Perth, Australia
commented

Looks good, no real complaints.

Thought about something more reliable than array keys?
as in a hidden value on rendered, e.g $rendered['#script_id'] = $script->id()

Im not going to hold off merging on this