Closed (fixed)
Project:
Blazy
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
8 Sep 2022 at 07:33 UTC
Updated:
14 Oct 2022 at 03:19 UTC
Jump to comment: Most recent
Drupal 9.5.0 has introduced a new deprecation:
The #drupal-off-canvas selector is deprecated in drupal:9.5.0 and is removed from drupal:10.0.0. See https://www.drupal.org/node/3305664.
The issue based on Upgrade Status is in the following file: /css/components/admin/blazy.admin--fixes.css
Run Upgrade Status on D9.5 for Blazy.
Fix the CSS selectors based on the change record.
-
-
-
-
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
balintpekkerComment #4
mglamanAfter reading the change record, this looks right. But it needs manual testing to verify there are no visual regressions.
Comment #5
gausarts commentedThank you.
I haven't read the CR nor checked compatibilty from D8 to D10+ yet, but if anyone beat me to it, kindly report your findings.
Basically those blazy CSS rules should be removed, since they were intended to actually play nice with off-canvas.
But when removed, we wanted to be sure no other blazy CSS rules leak into off-canvas. Otherwise they would mess up off-canvas, the reason those rules are there.
Initial attempt was removing all blazy CSS at Layout Builder pages here:
https://git.drupalcode.org/project/blazy/-/blob/8.x-2.13/src/Form/BlazyA...
Aside from global CSS removal at Blazy UI.
Simply put, I tend to think to totally remove all blazy CSS, not only those in your patch, using a different approach which is already existing like the above LB exclusion.
Only if off-canvas has particular routes. I haven't checked that out either.
If anyone know off-canvas routes, kindly try including them into the above LB exclusion line, and see anything breaking. If not, your patch might be in without that second thought.
Last time the above Layout Builder exclusion was a success, not sure about other off-canvas-related stuffs, the reason they are not removed yet.
Let me know your findings.
Comment #7
nkoporecI manually tested the MR and indeed as @gausarts already said, this off-canvas are not being used, so it is save to remove them all together. I updated the patch and remove them. I also updated the code that excludes the admin css from layout builder off canvas menus, so that it no longer looks for layout_builder. routes but instead it looks for a _wrapper_format parameter (drupal_dialog.off_canvas), this way the admin css will be excluded on all off-canvas menus and not only on layout builder ones.
Comment #9
gausarts commentedCommitted. Thank you for contribution and patience.