Closed (fixed)
Project:
Project Browser
Version:
1.0.x-dev
Component:
Meeting
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
31 Aug 2022 at 13:03 UTC
Updated:
14 Sep 2022 at 13:09 UTC
Jump to comment: Most recent
| AmyJune (volkswagenchick) | As an option too… there is a novice issue triage Bof for mentors on Monday at DC… We can add this project to the queue along with core.. |
| chrisfromredfin | #3224709: [API] Include API translation layer with mock/fixture implementation until d.o API is ready |
| chrisfromredfin | Fixed! :slightly_smiling_face: |
| fjgarlin | I am currently working on the actual d.o endpoint. We want to do it on what will be the D9 version of it. I’m currently working on the migration of data and have already been playing with jsonapi endpoints. I’ll update once I have something more solid but wanted to give an update |
| chrisfromredfin | The one thing I know we're gonna want to do is pass in our Drupal version (i.e. ?ver=9.3.6) and only get back projects who have a compatible release. |
| chrisfromredfin | That was amongst the trickiest things. I was figuring we'd have to index compatibility in solr somehow, like keeping the composer reqs as 080000000 as min and like 010000000 as max, and convert 9.3.6 to 090003006 and see if it fits between...? |
| chrisfromredfin | I think that's kinda how we do it now with major release, but now we're using Composer version constraints. |
| chrisfromredfin | OK. Some testing and discovery: #3274520: Unable to install the module with the current fixture |
| chrisfromredfin | From a code review standpoint it seems totally fine to me. From a testing standpoint, it still won't install on CLI with 64M (current Drupal memory_limit minimum requirement). But I wonder if it's worth merging as an incremental change, and see if it helps with SimplyTest.me and/or GitLabCI - where it does cli-based drush en's... it might just be how memory is being used in my local ddev?? |
| timplunkett (he/him) | I think 64M is for runtime, not necessarily for an admin experience |
| timplunkett (he/him) | I think 128M should be our threshold. Is it possible to test if the MR works with simplytest.me? (or post a patch equiv to use with it?) |
| narendraR | Let me know if a patch is required and I will upload that on ticket. |
| chrisfromredfin | I tried to use the gitlab mr .patch URL and Simplytest.me gave me an "invalid JSON" error so I presume it was something to do with an error on their side. |
| chrisfromredfin | image.png |
| timplunkett (he/him) | that's Simplytest.me's fault, not gitlab or the patch. But fyi, using .diff gives a more standardized form of the MR |
| timplunkett (he/him) | doesn't help here |
| chrisfromredfin | Actually, it's working! https://master-te8gwzp9lcypb3hewtq1sfvf65c184hb.tugboat.qa/admin/modules... |
| chrisfromredfin | image.png |
| chrisfromredfin | I just marked RTBC. |
| timplunkett (he/him) | Merged! |
Participants:
AmyJune (volkswagenchick), chrisfromredfin, fjgarlin, timplunkett (he/him), narendraR
Comments
Comment #6
chrisfromredfinComment #7
chrisfromredfinComment #8
chrisfromredfin