Coding Standards Meeting 2022-09-13 2100 UTC [#3306969]

Hello all, it’s time for the fortnightly coding standards meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for anyone interested in the Drupal coding standards.
➤ Usually happens fortnightly on Tuesday 2100 UTC. The meeting open for 24 hours to allow for all timezones.
➤ Is done on the #coding standards channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to. See the parent issue for an idea of the typical agenda.
➤A transcript will be made using drupal-meeting-parser and posted to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

Standing items

Who is here?
What should we talk about today? Suggest topics here and I will add threads. I will also check for comments on the issue for today's meeting.
Action Items
Approve previous minutes
Wrap up

0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all timezones.

quietone	Vicki. I have to leave in 40 minutes but the meeting stays open for 24 huors.
Björn Brala (bbrala)	waiting for kid to want to sleep. yay.
longwave	Dave, almost on time today

0️⃣.5️⃣ Name an interesting place you have visited

quietone	Punakaiki Pancake Rocks
longwave	https://en.wikipedia.org/wiki/Shell_Grotto,_Margate

2️⃣.1️⃣ Wins - what wins have you had since the last meeting? Share your successes!

Björn Brala (bbrala)	so.. many.. drupal 10 stuffs xD
longwave	^ this

2️⃣.2️⃣ Approve last fortnight's minutes

quietone	#3306969: Coding Standards Meeting 2022-09-13 2100 UTC but the minutes have yet to be transcribed.
quietone	Yesterday the meeting parser wasn't working for me. Maybe someone else could have a go?
Björn Brala (bbrala)	could tomorrow, but dont know where to find it.
quietone	Here it is, https://github.com/mdlutz24/drupal-meeting-parser
Björn Brala (bbrala)	thanks
Björn Brala (bbrala)	Why isn't it in the extension store :stuck_out_tongue:
Björn Brala (bbrala)	I was going to do this, but then i noticed. Minutes of last meeting were transcribed
Björn Brala (bbrala)	#3305394: Coding Standards Meeting 2022-08-30 2100 UTC
Björn Brala (bbrala)	I could still do these though, but will be a little earlier than 24 hours :wink:

2️⃣.3️⃣ What do you wnat to discuss? Add ideas in threads and I'll make a new discussion thread.

quietone	Review of issue in the "Review for beta'" bookmark folder
quietone	#2742881: Can inline comments end with semicolons
quietone	#2795237: Explicitly forbid tab stops within lines

3️⃣ Status of issues in the 'Review for beta' bookmark folder (top of channel)

quietone	All need review. Hopefully we all can find some time.
Björn Brala (bbrala)	I will put #3181778: [w/c September 17th] Replace t() with $this->t() in all plugins in my bucket to review. Should be able to to do that tomorrow.
Björn Brala (bbrala)	I'll actually do better and reserve time to focus on reviewing a few of those. Get things moving.
quietone	Do better? You have been doing awesome things for D10!
Björn Brala (bbrala)	Do better than review one issue I mean :slightly_smiling_face:
quietone	Ah, I see.
Björn Brala (bbrala)	And thank you. :wink:
quietone	I too should be able to do reviews tomorrow. But for most of them I can't RTBC.
Björn Brala (bbrala)	Yeah I noticed, i'll tag team and get RTBC's going hopefully where you put in the work
Björn Brala (bbrala)	Ok, got the first one in. It seems to need work.#3181778: [w/c September 17th] Replace t() with $this->t() in all plugins#comment-14692240
Björn Brala (bbrala)	Next one reviewed. (NW)#3268829: Fix class property comments for Drupal.Commenting.DocComment.ShortSingleLine#comment-14692457
Björn Brala (bbrala)	I can make the interdiff also ofc @quietone but just later. Seems you're offline now anyways, was hoping I catched you while you were still working :sweat_smile:
quietone	I came back and added it
Björn Brala (bbrala)	Yeah saw, and i know you know your stuff, but felt the need to at least mention it as always.
Björn Brala (bbrala)	:slightly_smiling_face:
Björn Brala (bbrala)	Hmm, and thanks :x
quietone	NW. I knew you knew that I knew. And I enjoyed the laugh. (I should be in bed!)
Björn Brala (bbrala)	:smile:
Björn Brala (bbrala)	go sleep :zzz-animated: good night!

4️⃣ #2742881: Can inline comments end with semicolons

quietone	The coding standards say that comments are to be sentences so I am thinking this is a won't fix.
Björn Brala (bbrala)	I've read through this and agree, closing is fine. Kinda agree on the fact that it's not really a needed change. Sentences is fine.
longwave	also agree; the only argument against appears to be code samples, but those should probably be in @code/@endcode ?
Björn Brala (bbrala)	or @example, so there is options, and also precedence in core. (edited)
Björn Brala (bbrala)	Commented on the issue, set to RTBC for now.

5️⃣ #2795237: Explicitly forbid tab stops within lines

quietone	The debate over tabs or spaces is long gone, so this may also be a won't fix.
Björn Brala (bbrala)	Yeah, random tabs are not used anywhere, people wont do it. The issue has no traction. Lets close it.
longwave	"with no tabs" is clear enough to me, and seemingly has been for years, let's not waste time on this
Björn Brala (bbrala)	Commented on the issue, set to RTBC for now.