Problem/Motivation

Duplication of selectors might indicate a copy-paste mistake. Unexpected duplicate selector ".webform-cards-toggle-wrapper", first used at line 39.

File: webform/modules/webform_cards/css/webform_cards.css

/**
 * Toggle.
 */
.webform-cards-toggle-wrapper {
  text-align: right; /* LTR */
}
...
.webform-cards-toggle-wrapper {
  margin-top: 1em;
}

Proposed resolution

/**
 * Toggle.
 */
.webform-cards-toggle-wrapper {
  margin-top: 1em;
  text-align: right; /* LTR */
}
CommentFileSizeAuthor
#3 duplicate_class_remove-3306594-3.patch601 bytesmeeni_dhobale

Comments

fnalb2 created an issue. See original summary.

meeni_dhobale’s picture

meeni_dhobale commented
Assigned: Unassigned » meeni_dhobale

Working on it.

meeni_dhobale’s picture

meeni_dhobale commented
Assigned: meeni_dhobale » Unassigned
Status: Active » Needs review
StatusFileSize
new duplicate_class_remove-3306594-3.patch601 bytes

Try to remove duplicate class. Please review it.

dharti patel’s picture

dharti patel commented
Assigned: Unassigned » dharti patel

I'll review this patch.

dharti patel’s picture

dharti patel commented
Assigned: dharti patel » Unassigned
Status: Needs review » Reviewed & tested by the community

Hello,

I've reviewed the #3 patch and after applying the patch removed the duplication CSS from the webform_cards.css file. Need to change the status RTBC.

Thanks!

jrockowitz’s picture

jrockowitz commented
Status: Reviewed & tested by the community » Fixed

  • 9db379e committed on 6.1.x 
    Issue #3306594 by Meeni_Dhobale: Unexpected duplicate selector ".webform...

  • 9db379e committed on 6.x 
    Issue #3306594 by Meeni_Dhobale: Unexpected duplicate selector ".webform...

  • 9db379e committed on 6.2.x 
    Issue #3306594 by Meeni_Dhobale: Unexpected duplicate selector ".webform...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.