Problem/Motivation

All the links present in module description page, on clicking load on the same page.

Steps to reproduce

Add target blank to all the links.

Proposed resolution

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Manual Testing
  • ✅ Accessibility Review
  • ✅ Automated tests written
  • ✅ Code Review

Issue fork project_browser-3306162

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Utkarsh_33 created an issue. See original summary.

utkarsh_33’s picture

utkarsh_33 commented
Status: Active » Needs review
utkarsh_33’s picture

utkarsh_33 commented
Assigned: utkarsh_33 » Unassigned

Utkarsh_33 opened merge request !235

srishtiiee made their first commit to this issue’s fork.

srishtiiee’s picture

srishtiiee commented
Status: Needs review » Reviewed & tested by the community

All the links on the detail page open in a new tab and the code looks good to go.👍🏼

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

Fix looks good!

This should be testable. You can adjust tests/fixtures/projects_fixture.json so that a test project has a link pointing to http://example.com

utkarsh_33’s picture

utkarsh_33 commented
Status: Needs work » Needs review
pflora’s picture

pflora commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

I've tested the changes made by @Utkarsh_33 and everything seems to be working as intended.
I also did a WAVE accessibility test and no new errors or warnings were found, i think we can check this one in the issue summary.
I have also manually tested the links in a bunch of projects and everytime the links open in a new tab, so checking this one too.

Since we have tests done, and the written code looks sound to me, i think this can be moved to RTBC.

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Issue tags: -Needs tests

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

Great work, thanks!

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.