Problem/Motivation

follow-up #3296261: Add the ability to map package names to project names and vice-versa

Instead of doing #3304142: Do not assume that Composer package names will exactly match Drupal projects names which is to do just conversion everywhere lets first try only taking on the change in ExtensionUpdater. This is will probably mean we need to also fix a bunch of other tests and/or the test fixtures but lets not try to fix all the validators themeselves in 1 issue if we don't have to .

Proposed resolution

Update ExtensionUpdater to use the new methods added in #3296261: Add the ability to map package names to project names and vice-versa. basically don't assume that for project_a the package name will be drupal/project_a but use \Drupal\package_manager\ComposerUtility::getProjectForPackage and \Drupal\package_manager\ComposerUtility::getPackageForProject as needed

This will make many tests fail. update the test and/or fixtures to make them pass.

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

tedbow created an issue. See original summary.

tedbow’s picture

Issue summary: View changes
tedbow’s picture

Status: Active » Needs work
omkar.podey’s picture

Assigned: Unassigned » omkar.podey
omkar.podey’s picture

Assigned: omkar.podey » Unassigned
omkar.podey’s picture

Assigned: Unassigned » omkar.podey
omkar.podey’s picture

Status: Needs work » Needs review
tedbow’s picture

Assigned: omkar.podey » tedbow
tedbow’s picture

Status: Needs review » Reviewed & tested by the community
tedbow’s picture

Status: Reviewed & tested by the community » Needs work

found some unneeded fixture files

for example automatic_updates_extensions/tests/fixtures/packages_installed_with_composer_validator/theme_not_installed.staged.installed.json
was copied to automatic_updates_extensions/tests/fixtures/packages_installed_with_composer_validator/theme_not_installed_stage/staged.installed.json but the original was not removed

I fixed this

  • tedbow committed 77b86bc on 8.x-2.x
    Issue #3305773 by omkar.podey, tedbow: Updates ExtensionUpdater to do...
tedbow’s picture

Status: Needs work » Fixed

@omkar.podey thanks, this looks good now. We have a lot of improvements here for handling fixtures!

I will un-postpone #3305564: Create a validator to stop newly installed packages from overwriting existing directories on apply

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.