Update all API methods to include return types.

CommentFileSizeAuthor
#34 metatag-n3305753-34.interdiff.txt384 bytesdamienmckenna
#34 metatag-n3305753-34.patch62.57 KBdamienmckenna
#32 metatag-n3305753-32.interdiff.txt681 bytesdamienmckenna
#32 metatag-n3305753-32.patch62.43 KBdamienmckenna
#30 metatag-n3305753-30.patch62.43 KBdamienmckenna
#30 metatag-n3305753-30.interdiff.txt2.14 KBdamienmckenna
#28 metatag-n3305753-28.patch61.63 KBdamienmckenna
#28 metatag-n3305753-28.interdiff.txt1.15 KBdamienmckenna
#27 metatag-n3305753-27.interdiff.txt35.28 KBdamienmckenna
#27 metatag-n3305753-27.patch61.63 KBdamienmckenna
#26 metatag-n3305753-26.patch26.35 KBdamienmckenna
#26 metatag-n3305753-26.interdiff.txt826 bytesdamienmckenna
#24 metatag-n3305753-24.patch26.33 KBdamienmckenna
#21 metatag-n3305753-21.patch25.54 KBdamienmckenna
#21 metatag-n3305753-21.interdiff.txt600 bytesdamienmckenna
#19 metatag-n3305753-19.interdiff.txt472 bytesdamienmckenna
#19 metatag-n3305753-19.patch25.49 KBdamienmckenna
#17 metatag-n3305753-17.interdiff.txt1.99 KBdamienmckenna
#17 metatag-n3305753-17.patch25.49 KBdamienmckenna
#15 metatag-n3305753-15.patch25.76 KBdamienmckenna
#15 metatag-n3305753-15.interdiff.txt3.55 KBdamienmckenna
#12 metatag-n3305753-12.patch24.53 KBdamienmckenna
#9 metatag-n3305753-9.patch8.09 KBdamienmckenna
#6 metatag-n3305753-6.patch8.09 KBdamienmckenna
#4 metatag-n3305753-4.patch15.72 KBdamienmckenna
#3 metatag-n3305753-2.patch8.78 KBdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 8.x-1.x-dev » 2.0.x-dev
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new metatag-n3305753-2.patch8.78 KB

On the main MetaNameBase class and the other Tag classes in the main module. Just to try.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n3305753-4.patch15.72 KB

Additional changes.

Status: Needs review » Needs work

The last submitted patch, 4: metatag-n3305753-4.patch, failed testing. View results

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n3305753-6.patch8.09 KB

Updated all custom plugins.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 6: metatag-n3305753-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n3305753-9.patch8.09 KB

Does this cover everything?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 9: metatag-n3305753-9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n3305753-12.patch24.53 KB

Does this work?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Update APIs to add return types on all methods » Update APIs to add return types on all methods of custom plugins

Status: Needs review » Needs work

The last submitted patch, 12: metatag-n3305753-12.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n3305753-15.interdiff.txt3.55 KB
new metatag-n3305753-15.patch25.76 KB

Further fixes.

Status: Needs review » Needs work

The last submitted patch, 15: metatag-n3305753-15.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n3305753-17.patch25.49 KB
new metatag-n3305753-17.interdiff.txt1.99 KB

Let's skip the return type from setValue().

Status: Needs review » Needs work

The last submitted patch, 17: metatag-n3305753-17.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n3305753-19.patch25.49 KB
new metatag-n3305753-19.interdiff.txt472 bytes

Once more.

Status: Needs review » Needs work

The last submitted patch, 19: metatag-n3305753-19.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n3305753-21.interdiff.txt600 bytes
new metatag-n3305753-21.patch25.54 KB

Does this work?

Status: Needs review » Needs work

The last submitted patch, 21: metatag-n3305753-21.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

This has been a major time sink and it's proving difficult to tie down exactly how much is needed.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n3305753-24.patch26.33 KB

This fixes one piece, we'll see if it fixes all of the problems.

Status: Needs review » Needs work

The last submitted patch, 24: metatag-n3305753-24.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n3305753-26.interdiff.txt826 bytes
new metatag-n3305753-26.patch26.35 KB

Hopefully this will resolve some tests.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n3305753-27.patch61.63 KB
new metatag-n3305753-27.interdiff.txt35.28 KB

More changes.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n3305753-28.interdiff.txt1.15 KB
new metatag-n3305753-28.patch61.63 KB

Whoops. This should work.

Status: Needs review » Needs work

The last submitted patch, 28: metatag-n3305753-28.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n3305753-30.interdiff.txt2.14 KB
new metatag-n3305753-30.patch62.43 KB

One more try.

Status: Needs review » Needs work

The last submitted patch, 30: metatag-n3305753-30.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n3305753-32.patch62.43 KB
new metatag-n3305753-32.interdiff.txt681 bytes

Doh.

Status: Needs review » Needs work

The last submitted patch, 32: metatag-n3305753-32.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n3305753-34.patch62.57 KB
new metatag-n3305753-34.interdiff.txt384 bytes

Hopefully this is the last one.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

I created a draft change notice: https://www.drupal.org/node/3335416

  • DamienMcKenna committed 31bf68bd on 2.0.x 
    Issue #3305753 by DamienMcKenna: Add return types on all custom class...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Update APIs to add return types on all methods of custom plugins » Add return types on all custom class methods
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.