Fix coding standards issues [#3305751]

Comment	File	Size	Author
#25	metatag-n3305751-25.patch	24.47 KB	damienmckenna
#25	metatag-n3305751-25.interdiff.txt	6.94 KB	damienmckenna
#23	metatag-n3305751-23.patch	18.4 KB	damienmckenna
#23	metatag-n3305751-23.interdiff.txt	5.77 KB	damienmckenna
#20	metatag-n3305751-19-src.patch	6.52 KB	damienmckenna
#20	metatag-n3305751-19.interdiff.txt	492 bytes	damienmckenna
#16	metatag-n3305751-16-mfiles.patch	13.58 KB	damienmckenna
#16	metatag-n3305751-16-src.patch	6.82 KB	damienmckenna
#13	metatag-n3305751-13.patch	13.48 KB	damienmckenna
#12	metatag-n3305751-12.patch	20.4 KB	damienmckenna
#10	metatag-n3305751-10.patch	33.82 KB	damienmckenna
#10	metatag-n3305751-10.interdiff.txt	679 bytes	damienmckenna
#9	metatag-n3305751-8.patch	38.24 KB	damienmckenna
#9	metatag-n3305751-8.interdiff.txt	679 bytes	damienmckenna
#8	date-n2898235-39.patch	26.5 KB	damienmckenna
#8	date-n2898235-39.interdiff.txt	1.6 KB	damienmckenna
#6	metatag-n3305751-6.patch	33.64 KB	damienmckenna
#5	metatag-n3305751-5.patch	1.91 KB	damienmckenna
#4	metatag-n3305751-4.patch	2.5 KB	damienmckenna

Comment #1

24 August 2022 at 14:27

DamienMcKenna created an issue. See original summary.

Log in or register to post comments

Comment #2

damienmckenna

TN, USA

commented 24 August 2022 at 14:28

Title:

Fix coding standards issue

» Fix coding standards issues

Log in or register to post comments

Comment #3

damienmckenna

TN, USA

commented 24 August 2022 at 14:28

Log in or register to post comments

Comment #4

damienmckenna

TN, USA

commented 24 August 2022 at 14:39

Status	File	Size
new	metatag-n3305751-4.patch	2.5 KB

WIP.

Log in or register to post comments

Comment #5

damienmckenna

TN, USA

commented 24 August 2022 at 18:00

Status:

Active

» Needs review

Status	File	Size
new	metatag-n3305751-5.patch	1.91 KB

Further WIP, hopefully this doesn't cause regressions.

Log in or register to post comments

Comment #6

damienmckenna

TN, USA

commented 24 August 2022 at 19:16

Status	File	Size
new	metatag-n3305751-6.patch	33.64 KB

2 files were hidden/shown/deleted

Status	File	Size
hidden	metatag-n3305751-4.patch	2.5 KB
hidden	metatag-n3305751-5.patch	1.91 KB

The correct patch.

Log in or register to post comments

Comment #7

24 August 2022 at 19:26

Status:

Needs review

» Needs work

The last submitted patch, 6: metatag-n3305751-6.patch, failed testing. View results

Log in or register to post comments

Comment #8

damienmckenna

TN, USA

commented 9 September 2022 at 18:06

Assigned:	Unassigned	» damienmckenna
Status:	Needs work	» Needs review

Status	File	Size
new	date-n2898235-39.interdiff.txt	1.6 KB
new	date-n2898235-39.patch	26.5 KB

Should resolve one of the errors.

Log in or register to post comments

Comment #9

damienmckenna

TN, USA

commented 9 September 2022 at 18:07

Status	File	Size
new	metatag-n3305751-8.interdiff.txt	679 bytes
new	metatag-n3305751-8.patch	38.24 KB

2 files were hidden/shown/deleted

Status	File	Size
hidden	date-n2898235-39.interdiff.txt	1.6 KB
hidden	date-n2898235-39.patch	26.5 KB

Those were the wrong patches X-)

Log in or register to post comments

Comment #10

damienmckenna

TN, USA

commented 9 September 2022 at 18:34

Status	File	Size
new	metatag-n3305751-10.interdiff.txt	679 bytes
new	metatag-n3305751-10.patch	33.82 KB

Uh?

Log in or register to post comments

Comment #11

9 September 2022 at 18:44

Status:

Needs review

» Needs work

The last submitted patch, 10: metatag-n3305751-10.patch, failed testing. View results

Log in or register to post comments

Comment #12

damienmckenna

TN, USA

commented 23 September 2022 at 20:31

Status:

Needs work

» Needs review

Status	File	Size
new	metatag-n3305751-12.patch	20.4 KB

Without the test changes.

Log in or register to post comments

Comment #13

damienmckenna

TN, USA

commented 23 September 2022 at 20:32

Status	File	Size
new	metatag-n3305751-13.patch	13.48 KB

Just the test changes.

Log in or register to post comments

Comment #14

23 September 2022 at 20:42

The last submitted patch, 12: metatag-n3305751-12.patch, failed testing. View results

Log in or register to post comments

Comment #15

23 September 2022 at 20:42

Status:

Needs review

» Needs work

The last submitted patch, 13: metatag-n3305751-13.patch, failed testing. View results

Log in or register to post comments

Comment #16

damienmckenna

TN, USA

commented 23 September 2022 at 21:08

Status:

Needs work

» Needs review

Status	File	Size
new	metatag-n3305751-16-src.patch	6.82 KB
new	metatag-n3305751-16-mfiles.patch	13.58 KB

Splitting it up even more.

Log in or register to post comments

Comment #17

23 September 2022 at 21:20

The last submitted patch, 16: metatag-n3305751-16-src.patch, failed testing. View results

Log in or register to post comments

Comment #18

23 September 2022 at 21:31

DamienMcKenna committed a3384c8 on 8.x-1.x

Issue #3305751 by DamienMcKenna: Fix coding standards issues.

Log in or register to post comments

Comment #19

damienmckenna

TN, USA

commented 24 September 2022 at 00:25

Status:

Needs review

» Needs work

I committed metatag-n3305751-16-mfiles.patch.

Now to work on the other changes.

Log in or register to post comments

Comment #20

damienmckenna

TN, USA

commented 26 September 2022 at 18:17

Status:

Needs work

» Needs review

Status	File	Size
new	metatag-n3305751-19.interdiff.txt	492 bytes
new	metatag-n3305751-19-src.patch	6.52 KB

I think I introduced a bug in an earlier patch, this should work.

Log in or register to post comments

Comment #21

26 September 2022 at 18:35

DamienMcKenna committed 4369ba4 on 8.x-1.x

Issue #3305751 by DamienMcKenna: Fix coding standards issues.

Log in or register to post comments

Comment #22

damienmckenna

TN, USA

commented 26 September 2022 at 18:36

Status:

Needs review

» Needs work

Committed. Now for the tests.

Log in or register to post comments

Comment #23

damienmckenna

TN, USA

commented 26 September 2022 at 20:39

Status:

Needs work

» Needs review

Status	File	Size
new	metatag-n3305751-23.interdiff.txt	5.77 KB
new	metatag-n3305751-23.patch	18.4 KB

Log in or register to post comments

Comment #24

26 September 2022 at 20:50

Status:

Needs review

» Needs work

The last submitted patch, 23: metatag-n3305751-23.patch, failed testing. View results

Log in or register to post comments

Comment #25

damienmckenna

TN, USA

commented 26 September 2022 at 21:21

Status:

Needs work

» Needs review

Status	File	Size
new	metatag-n3305751-25.interdiff.txt	6.94 KB
new	metatag-n3305751-25.patch	24.47 KB

2 files were hidden/shown/deleted

Status	File	Size
hidden	metatag-n3305751-23.interdiff.txt	5.77 KB
hidden	metatag-n3305751-23.patch	18.4 KB

Log in or register to post comments

Comment #26

damienmckenna

TN, USA

commented 26 September 2022 at 21:34

Status:

Needs review

» Fixed

Committed.

Log in or register to post comments

Comment #27

26 September 2022 at 21:34

DamienMcKenna committed 6490cf4 on 8.x-1.x

Issue #3305751 by DamienMcKenna: Fix coding standards issues.

Log in or register to post comments

Comment #28

damienmckenna

TN, USA

commented 26 September 2022 at 21:35

Status:

Needs review

» Fixed

Log in or register to post comments

Comment #29

damienmckenna

TN, USA

commented 26 September 2022 at 21:35

Assigned:

damienmckenna

» Unassigned

Log in or register to post comments

Comment #30

10 October 2022 at 21:39

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Log in or register to post comments

Fix coding standards issues

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

Comment #20

Comment #21

Comment #22

Comment #23

Comment #24

Comment #25

Comment #26

Comment #27

Comment #28

Comment #29

Comment #30

Parent issue

Related issues

Referenced by

News items

Our community

Documentation

Drupal code base

Governance of community