Problem/Motivation

drupalci updated the composer version to 2.3.6, meaning that we are actually downgrading the version of composer to run our tests. A line was added to make sure we'd be using 2.3.5 when that was not included by default, but now that we have a similar version, we no longer need this.

Steps to reproduce

See drupalci.yml file.

Proposed resolution

Remove the line.

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Manual Testing
  • ☐ Code Review
  • ☐ Accessibility Review
  • ☐ Automated tests needed/written?

Issue fork project_browser-3305515

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fjgarlin created an issue. See original summary.

fjgarlin’s picture

fjgarlin commented
Assigned: Unassigned » fjgarlin

fjgarlin opened merge request !231

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented

we still want to do #3302524: Support Composer 2.2 to allow users to use Composer 2.2.* but since it was created Drupalci itself seems to be use Composer > 2.3.5 so there is no longer a need to update before the tests run.
Right now it is actually downgrading Drupalci's composer from 2.3.6 to 2.3.5(originally it was upgrading from 2.2.? to 2.3.5)

fjgarlin’s picture

fjgarlin commented
Status: Active » Needs review
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs review » Reviewed & tested by the community

Looks good! Thanks @fjgarlin

tim.plunkett made their first commit to this issue’s fork.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Assigned: fjgarlin » Unassigned
Status: Reviewed & tested by the community » Fixed

#4 good to know! Thanks for following up.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

Fixing credit, sorry @tedbow

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.