Problem/Motivation

We need to manually test that the upgrade path from Quick Edit in core in 9.5.x to contrib in 10.0.x is smooth.

Steps to reproduce

Proposed resolution

Use @bbrala's excellent instructions for Color module as a basis: #3302799: Manually test color module removal

Install Drupal 9.4

  1. Install Drupal 9.4 composer create-project drupal/recommended-project:9.4.* drupal-quickedit
  2. Move into the directory cd drupal-quickedit
  3. Enable development settings cp web/sites/example.settings.local.php web/sites/default/settings.local.php
  4. Add Drush composer require drush/drush
  5. Install with Umami vendor/bin/drush si demo_umami
  6. Enable settings.local.php at the end of web/sites/default/settings.php

Enable and test Quick Edit

  1. Enable the module vendor/bin/drush en -y quickedit
  2. Log into the site and use Quick Edit to make some changes.

Choose your own adventure

At this point, you can either test what happens if you install the contrib Quick Edit or not.

Either upgrade to contrib and test again
  1. composer require drupal/quickedit
vendor/bin/drush cr
  2. Log into the site and use Quick Edit to make some changes.
Or do nothing and expect errors at the next phase

If you don't install the contrib project, and do not uninstall the core version before you upgrade, you should get errors via update.php (and warnings via drush updb) about the missing core module. See also #3294914: Create dedicated error section for missing removed core modules/themes on update.

Upgrade to Drupal 10 and test again

  1. composer config minimum-stability dev
composer require drupal/core-composer-scaffold:10.0.x-dev drupal/core-project-message:10.0.x-dev drupal/core-recommended:10.0.x-dev drush/drush -W
  2. Remove the core copy of Quick Edit. Either:
  3. Update to D10. Either:
    • Via the UI: visit update.php for the local test site
    • Via drush:
      vendor/bin/drush updb
vendor/bin/drush cr
  4. Log into the site and either:
    • use Quick Edit to make some changes
    • or experience errors at admin/reports/status

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
Related issues: +#3291700: new subtree split of core Quick Edit into contrib (v2)

D10 compatibility requires the patch from #3291700: new subtree split of core Quick Edit into contrib (v2).

Install Drupal 9.4

  1. Install Drupal 9.4 composer create-project drupal/recommended-project:9.4.* drupal-quickedit
  2. Move into the directory cd drupal-quickedit
  3. Enable development settings cp web/sites/example.settings.local.php web/sites/settings.local.php
  4. Add Drush composer require drush/drush
  5. Install with Umami vendor/bin/drush si demo_umami

Enable and test Quick Edit

  1. Enable the module vendor/bin/drush en -y quickedit
  2. Log into the site and use Quick Edit to make some changes.

Upgrade to contrib and test again

  1. composer require drupal/quickedit
vendor/bin/drush cr
  2. Log into the site and use Quick Edit to make some changes.

Upgrade to patched Quick Edit

  1. composer require cweagans/composer-patches
composer config --json extra.patches.drupal/quickedit '{"D10 compatibility": "https://git.drupalcode.org/project/quickedit/-/merge_requests/7.diff"}'
composer update drupal/quickedit
vendor/bin/drush cr
  2. Log into the site and use Quick Edit to make some changes.

Upgrade to Drupal 10 and test again

    composer config minimum-stability dev
composer require drupal/core-composer-scaffold:10.0.x-dev drupal/core-project-message:10.0.x-dev drupal/core-recommended:10.0.x-dev drush/drush -W
vendor/bin/drush updb
vendor/bin/drush cr
  1. Log into the site and use Quick Edit to make some changes.
dww’s picture

dww
we/he/they
commented
Issue summary: View changes

QE 1.0.2 is now out. 🎉

Moving the instructions into the summary, and simplifying them since you no longer need to patch anything.

dww’s picture

dww
we/he/they
commented
Issue summary: View changes

I've tried this now myself, so I'd call it RTBC, but that'd sort of be like doing so on my own patch. 😅

dww’s picture

dww
we/he/they
commented
Issue summary: View changes

Per @catch, adding an explicit step to remove D10 core quickedit.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

I think it is fine for anyone to RTBC this if they followed my steps and got the same result, whether they are maintainer of the module or not :)

dww’s picture

dww
we/he/they
commented
Issue summary: View changes

Sure, but I didn’t follow your steps. I changed the steps considerably, so they’re now “our” steps and I don’t think my hands are clean enough to RTBC now. 😅

dww’s picture

dww
we/he/they
commented
Issue summary: View changes

Added notes about testing what happens if you enable core 9.4.* QE, do not install contrib, and try to upgrade to D10.

dww’s picture

dww
we/he/they
commented
Issue summary: View changes
catch’s picture

catch
he/him
Primary language English
commented

Hate to ask this, but was 10.x tested without lines like this in core: https://git.drupalcode.org/project/drupal/-/merge_requests/2389#note_112760

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

The Quick Edit metadata issue will be resolved in contrib by #3304893: Add Quick Edit metadata to core field formatters when @dww returns and also committed to 9.5.x in #3270434: Mark Quick Edit deprecated.

bbrala’s picture

bbrala
Location Netherlands
commented
Status: Needs review » Reviewed & tested by the community

I've went through the whole process outlines by longwave. Quick edit basically works as intented. I used the path of installing quickedit in 9, then upgrading. The path is smooth as stone. No logged errors, no js errors, quickedit works.

The comment by catch in #10 as that been been extensively tested by @catch in the related issue.

This is great! RTBC <3 :)

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Hooray!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.