Problem/Motivation
For the removal process we need to go through manual testing. I've documented a set of steps. I will use these to test color. See: https://www.drupal.org/project/project_composer/issues/3299191#comment-1...
Steps to reproduce
n.a.
Proposed resolution
Run an adjusted test script for color.
Remaining tasks
Do the testing
User interface changes
n.a.
API changes
n.a.
Data model changes
n.a.
Release notes snippet
n.a.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | Toolbox 2022.08.10 - 13.47.55.01-encoded.mp4 | 30.94 MB | bbrala |
Comments
Comment #2
bbralaPossible contrib to use to test dependency:
Comment #3
bbralahmm, those wont do, looking for a theme.
Comment #4
spokjeWould this help:
https://git.drupalcode.org/search?group_id=2&repository_ref=&scope=blobs...
Projects with color.inc, without references to bartik and without
arrayin them, which would indicate D7 stuff.Comment #5
longwavehttps://www.drupal.org/project/honey looks like a good test candidate. It is a simple theme written as an example for the user guide, and contains a bunch of color module configuration options.
Comment #6
bbralaThanks guys, will look at those. Found another one which just adds a color picker to the theme settings that might work.
Will continue tonight. I did notice the parent issue might need a rebate since it doesn't run on php8 (when updating to d10) because of laminas. Think this means an old composer.json but will double check that also tonight.
Comment #7
spokjeHmm, parent (#3270899: Remove Color module from core) is on 10.0.x, so PHP 8.1, not sure if you've used PHP 8.0 for your tests?
Anyway: Parent did have a merge-conflict, that should be fixed now.
Comment #8
bbralaHoney installs and works when combined with:
Then replace
^9with^9 || ^10in thehoney.info.ymland it installs and loads. I'll go through these steps cleanly and document. The color picker does show in d10 at least with the contrib.Added longwave and spokje to credits for looking for possible contrib modules to use to test.
Comment #9
bbrala> Hmm, parent (#3270899: [PP-1] Remove Color module from core) is on 10.0.x, so PHP 8.1, not sure if you've used PHP 8.0 for your tests?
I use 8.1, but it seems the problem was something else. It couldn't resolve to a good set of dependencies, which kept laminas back and therefor mentioned the php version as a possible reason. So thats a false alarm.
The whole depenency resolution information of composer is a bit confusing smoethings.
Comment #10
bbralaThis is the steps i did. All seemed fine. But after applying the patch in the parent issue it is missing some css. But, the color picker is working as expected.
Below what i did:
Manually test for upgrading from the core module to the contrib module.
Install Drupal 9.3 on a machine with composer.
composer create-project "drupal/recommended-project:9.3.*" drupal-module-colorcd drupal-module-colorcp web/sites/example.settings.local.php web/sites/settings.local.phpcomposer require drush/drushbecause life is better with Drush :)vendor/bin/drush si demo_umamiEnable and configure the module
vendor/bin/drush en color --yesvendor/bin/drush cex --yesThen set as default theme
core_version:requirement: ^9 || ^10Test the module (9.3)
http://drupal-module-color.web.swisdev.nl/en/admin/appearance/settings/honeyNow we are going to upgrade to Drupal 9.4. Easy as ever.
composer updatevendor/bin/drush updb.Test module again (9.4)
http://drupal-module-color.web.swisdev.nl/en/admin/appearance/settings/honeyUpdate to contrib
composer require drupal/colorto require the new contrib moduleTest module again (9.4)
http://drupal-module-color.web.swisdev.nl/en/admin/appearance/settings/honeyNow we are going to upgrade to Drupal 10. Easy as ever.
composer updatevendor/bin/drush updb.vendor/bin/drush crTest module again
http://drupal-module-color.web.swisdev.nl/en/admin/appearance/settings/honeySuccess!
You've now successfully tested the module. For other modules this might be more steps in regards to the testing steps since they have more moving parts.
Comment #11
bbralaOk the problem in 10 was the weird patch not applying normally.
I did a core install with the branch of the parent patch, installed honey with lenient. There were no color options. Installed and enabled contrib color, and everything worked as expected.
I declare this verified.
Comment #12
andypostI think I need to merge few commits into contrib color module as there was changes in core, but can't find the guide how to upgrade this split
Comment #13
longwaveRTBC. Thanks for the great set of test steps. I have replicated the manual test, poked around in the database for paths, and clicked around my test site and confirm that everything continues to work as expected in Honey theme when Color module has been removed from core and replaced with the contrib version.
@andypost I think that should be done outside of this issue, this is for manual testing only?
Comment #14
andypostsure ++rtbc (I just lost in issues)
Comment #15
longwave@andypost Opened #3302976: Port remaining changes from core to track that
Comment #16
xjmWell done, thanks everyone!