Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
RDF module is being removed from Drupal 10. It has already been removed from Standard in #3243121: Remove RDF module from the Standard profile but the Umami demo still installs it.
Steps to reproduce
Proposed resolution
Remove RDF from the Umami demo profile.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3302984
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
longwaveComment #5
smustgrave CreditAttribution: smustgrave at Mobomo commentedSaw there was still 1 file left rdf.mapping.taxonomy_term.tags.yml went ahead and removed that.
Comment #6
smustgrave CreditAttribution: smustgrave at Mobomo commentedSince I just removed the one file can I mark RTBC?
Comment #7
quietone CreditAttribution: quietone at PreviousNext commentedAfraid not, there is no code review here.
Reviewed & tested by the community
And, as happens, I am currently looking at this and I have questions that I am still investigating.
edit: fix grammar
Comment #8
quietone CreditAttribution: quietone at PreviousNext commentedApplied the MR locally and searched for rdf in the umami profile
So, no 'rdf' strings or filenames with rdf.
Looking at ConfirmClassyCopiesTest I've learned that each theme has a 'rdf-metadata.html.twig' file. I don't know twigland but if that file needs to be removed here then it will have to be removed from the other themes as well. That should be in a followup up.
Comment #9
SpokjeI'm certainly not a seasoned tour guide in "Twig-Land", but in other deprecation/removal issues for core modules/themes, we agreed on the following:
Remove the templates in themes that will stay in core (Claro, Olivero, Starterkit, Umami), leave them in the others (Bartik, Classy, Seven, Stable, Stable9, Stark).
The above goes for templates as well as (P)CSS files.
(https://www.drupal.org/project/drupal/issues/3264120#comment-14456294 and https://www.drupal.org/project/drupal/issues/3227033#comment-14576164)
Comment #10
SpokjeHaving said that, and looking at
\Drupal\KernelTests\Core\Theme\ConfirmClassyCopiesTest::providerTestClassyCopies
there's no way it can pass when we _don't_ remove the RDF-related template.So I'm going to mark this issue as RTBC.
@quietone said:
I suppose if we need to remove templates, we'll do it in the actual removal issue of the RDF module. If that's a false assumption (I've been know to make a few of those before), it will indeed be a follow-up that pops up somewhere, don't _think_ we need to file one just yet.
Comment #12
catchI think it's reasonable to remove the templates in the patch that removes RDF, can't remember what we did for aggregator which is the only module with templates I can think of we've removed recently.
Committed/pushed to 10.1.x, cherry-picked to 10.0.x and 9.5.x, thanks!
Comment #13
SpokjeFor the record: With aggregator we removed the templates from the dataProvider in the removal issue: https://www.drupal.org/project/drupal/issues/3264120#mr1811-note81861