Problem/Motivation

RDF module is being removed from Drupal 10. It has already been removed from Standard in #3243121: Remove RDF module from the Standard profile but the Umami demo still installs it.

Steps to reproduce

Proposed resolution

Remove RDF from the Umami demo profile.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3302984

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave created an issue. See original summary.

longwave’s picture

Status: Active » Needs review

smustgrave made their first commit to this issue’s fork.

smustgrave’s picture

Saw there was still 1 file left rdf.mapping.taxonomy_term.tags.yml went ahead and removed that.

smustgrave’s picture

Since I just removed the one file can I mark RTBC?

quietone’s picture

Afraid not, there is no code review here.

The patch has received a thorough review and test by one or more community members, and they have deemed it as ready to be committed to the project.

Reviewed & tested by the community

And, as happens, I am currently looking at this and I have questions that I am still investigating.

edit: fix grammar

quietone’s picture

Applied the MR locally and searched for rdf in the umami profile

$ grep -ri rdf core/profiles/demo_umami/
grep: core/profiles/demo_umami/modules/demo_umami_content/default_content/images/veggie-pasta-bake-hero-umami.jpg: binary file matches
$ find core/profiles/demo_umami/ -iname \*rdf\*
$

So, no 'rdf' strings or filenames with rdf.

Looking at ConfirmClassyCopiesTest I've learned that each theme has a 'rdf-metadata.html.twig' file. I don't know twigland but if that file needs to be removed here then it will have to be removed from the other themes as well. That should be in a followup up.

Spokje’s picture

I'm certainly not a seasoned tour guide in "Twig-Land", but in other deprecation/removal issues for core modules/themes, we agreed on the following:

Remove the templates in themes that will stay in core (Claro, Olivero, Starterkit, Umami), leave them in the others (Bartik, Classy, Seven, Stable, Stable9, Stark).

The above goes for templates as well as (P)CSS files.

(https://www.drupal.org/project/drupal/issues/3264120#comment-14456294 and https://www.drupal.org/project/drupal/issues/3227033#comment-14576164)

Spokje’s picture

Status: Needs review » Reviewed & tested by the community

Having said that, and looking at \Drupal\KernelTests\Core\Theme\ConfirmClassyCopiesTest::providerTestClassyCopies there's no way it can pass when we _don't_ remove the RDF-related template.

So I'm going to mark this issue as RTBC.

@quietone said:

I don't know twigland but if that file needs to be removed here then it will have to be removed from the other themes as well. That should be in a followup up.

I suppose if we need to remove templates, we'll do it in the actual removal issue of the RDF module. If that's a false assumption (I've been know to make a few of those before), it will indeed be a follow-up that pops up somewhere, don't _think_ we need to file one just yet.

  • catch committed 1fd70d1 on 10.0.x
    Issue #3302984 by longwave, smustgrave, quietone, Spokje: Remove RDF...
  • catch committed 42a7743 on 10.1.x
    Issue #3302984 by longwave, smustgrave, quietone, Spokje: Remove RDF...
  • catch committed 41e55af on 9.5.x
    Issue #3302984 by longwave, smustgrave, quietone, Spokje: Remove RDF...
catch’s picture

Status: Reviewed & tested by the community » Fixed

I think it's reasonable to remove the templates in the patch that removes RDF, can't remember what we did for aggregator which is the only module with templates I can think of we've removed recently.

Committed/pushed to 10.1.x, cherry-picked to 10.0.x and 9.5.x, thanks!

Spokje’s picture

For the record: With aggregator we removed the templates from the dataProvider in the removal issue: https://www.drupal.org/project/drupal/issues/3264120#mr1811-note81861

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.