Problem/Motivation

Drupal.theme.ajaxWrapperMultipleRootElements
Drupal.theme.ajaxWrapperNewContent

were 'deprecated' in Drupal 8.6.0 before we had a JavaScript deprecation API. We need to actually deprecate them, so they can be removed. Should probably be deprecated in 8.6.0 for removal in 11.0.0 at this point.
https://www.drupal.org/node/2940704

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#10 core-3301204-10.patch2.45 KBmedha kumari
#9 3301204-9.patch3.04 KBpradhumanjain2311
#7 core-3301204-7.patch2.45 KB_shy
#5 core-3301204-5.patch4.3 KB_shy
#3 core-3301204-3.patch4.02 KB_shy

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Parent issue: » #3301206: [meta] Fix incomplete/incorrect deprecations in Drupal core
_shy’s picture

_shy
Primary language Ukrainian
Location Ukraine, Lutsk 🇺🇦
commented
StatusFileSize
new core-3301204-3.patch4.02 KB

Deprecates according to the JavaScript Deprecation API: https://www.drupal.org/about/core/policies/core-change-policies/drupal-d...

_shy’s picture

_shy
Primary language Ukrainian
Location Ukraine, Lutsk 🇺🇦
commented
Status: Active » Needs review
_shy’s picture

_shy
Primary language Ukrainian
Location Ukraine, Lutsk 🇺🇦
commented
StatusFileSize
new core-3301204-5.patch4.3 KB

Reworked patch.

quietone’s picture

quietone commented
Status: Needs review » Needs work

@_shY, thanks for making a patch!

The patch is failing on build checks. You can run the check locally to make sure those checks pass before uploading a patch. Have a look at the instructions for running the coding standard checks locally so you can be sure the tests will run before uploading a patch.

_shy’s picture

_shy
Primary language Ukrainian
Location Ukraine, Lutsk 🇺🇦
commented
Status: Needs work » Needs review
StatusFileSize
new core-3301204-7.patch2.45 KB

@quietone, thanks for the suggestion!
Hope this time all coding standard checks will be passed.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll
pradhumanjain2311’s picture

pradhumanjain2311 commented
Status: Needs work » Needs review
StatusFileSize
new 3301204-9.patch3.04 KB

Addressed comment #8.

medha kumari’s picture

medha kumari
Location Jaipur
commented
Issue tags: -Needs reroll
StatusFileSize
new core-3301204-10.patch2.45 KB

Reroll the patch #7 with 10.1.x

The last submitted patch, 9: 3301204-9.patch, failed testing. View results

nod_’s picture

nod_
Primary language French
Location Lille
commented

There are no .es6.js files in the 10.0+ branches

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Needs work

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Status: Needs work » Closed (duplicate)

Closed as a duplicate of #3352549: Remove deprecations in ajax.js. Moving credit over there.