Problem/Motivation

Late in Drupal 8.8.x cycle, we provided tools for deprecating JavaScript code. Unfortunately, we didn't manage to properly deprecate any of the JavaScript code so that they could be removed before Drupal 9.0.0.

Proposed resolution

Update documentation on deprecated JavaScript code to make it clear that the removals will happen before Drupal 10.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#9 3114116-9.patch1.98 KBandypost
#3 3114116-3.patch1.25 KBlauriii
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lauriii created an issue. See original summary.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Parent issue: » #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Active » Needs review
FileSize
3114116-3.patch1.25 KB
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Issue tags: +Needs change record updates
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented 
+++ b/core/misc/ajax.es6.js
@@ -1117,7 +1117,7 @@
+   * @deprecated in Drupal 8.6.x and will be removed before Drupal 10.0.0.
    *   Use data with desired wrapper. See https://www.drupal.org/node/2974880.

@@ -1146,7 +1146,7 @@
+   * @deprecated in Drupal 8.6.x and will be removed before Drupal 10.0.0.
    *   Use data with desired wrapper. See https://www.drupal.org/node/2974880.

somehow https://www.drupal.org/node/2974880 link returns 404 for me

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Issue tags: +Needs release manager review

Good point @andypost. I'm tagging this for release manager review. Let's wait for a confirmation from them before moving forward on updating the change records.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Needs review » Needs work

Apparently https://www.drupal.org/node/2940704 is where the link should post. I think the change records would only be updated after commit anyway, as before commit there is no guarantees the updated change record reflects reality :) So IMHO updating the code comment here to point to that change record and then getting this to RTBC would be best. Release managers could still review it then :) The presence of the tag should ensure that other committers don't commit it accidentally.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Issue tags: +Drupal 9.0.0-beta1 requirement
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs work » Needs review
FileSize
3114116-9.patch1.98 KB

Not sure sniffers parse JS files but the missing CR https://www.drupal.org/node/2928117 it was fixed in #2928137: Correct deprecation note in ajax.es6.js

So here's a patch with fixed coding standards

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

LGTM!

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Needs review » Reviewed & tested by the community

  • catch committed fe07650 on 9.0.x 
    Issue #3114116 by lauriii, andypost, Gábor Hojtsy: Re-schedule removal...

  • catch committed 1cfbe9e on 8.9.x 
    Issue #3114116 by lauriii, andypost, Gábor Hojtsy: Re-schedule removal...

  • catch committed a2bd2a1 on 8.8.x 
    Issue #3114116 by lauriii, andypost, Gábor Hojtsy: Re-schedule removal...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 8.9.x-dev » 8.8.x-dev
Status: Reviewed & tested by the community » Fixed

So IMO if we had a proper change record, and core usages were removed, it would still be fine to remove these bc layers in Drupal 9.

However I don't mind deferring the deprecation either, so committed/pushed to 8.8.x/8.9.x/9.0.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue tags: -Needs release manager review