Problem/Motivation

Make the module Drupal10 ready. Upgrade Status reported the following issues:
- The 'drupal.environment_indicator' library is depending on a deprecated library. The core/jquery.once asset library is deprecated in Drupal 9.3.0 and will be removed in Drupal 10.0.0. Use the core/once library instead. See https://www.drupal.org/node/3158256
- Value of core_version_requirement: ^8.8 || ^9 is not compatible with the next major version of Drupal core.

Steps to reproduce

-

Proposed resolution

Fix issues reported by Upgrade Status, and check if there are any other issues holding back the module from being D10 ready. (drupal-check)

Remaining tasks

Fix Upgrade Status reported issues, run drupal-check, run tests.

User interface changes

-

API changes

-

Data model changes

-

Issue fork environment_indicator-3301118

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

balintpekker created an issue. See original summary.

balintpekker opened merge request !7

balintpekker’s picture

balintpekker
he/him
Primary language Hungarian
Location Budapest, Hungary
commented

After testing the changes in the PR manually both on D10 and D9.5 I noticed a change which possibly is not affected by the changes made in the PR and is a separate issue.

The issue is when you are setting the current environment through the config form on D10 you need to rebuild the caches in order to see the changes, however when you do the same on D9.5, the changes apply after saving the config form. I'd possibly create a new issue not to hold up the D10 readiness changes.

Related issue: https://www.drupal.org/project/environment_indicator/issues/2406619#comm...

balintpekker’s picture

balintpekker
he/him
Primary language Hungarian
Location Budapest, Hungary
commented
Status: Active » Needs review

mglaman made their first commit to this issue’s fork.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

I didn't RTBC because I bumped minimum drupal/core to 9.2

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Status: Needs review » Reviewed & tested by the community

The changes looks good to me, setting as RTBC.

balintpekker’s picture

balintpekker
he/him
Primary language Hungarian
Location Budapest, Hungary
commented
Assigned: balintpekker » Unassigned

e0ipso made their first commit to this issue’s fork.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Reviewed & tested by the community » Fixed
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented

Thanks everyone for the work here!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.